1888/public temporary conversion - #2066
Open
MarcelKoch wants to merge 6 commits into
Open
Conversation
ginkgo-bot
added
reg:build
Member
|
is there any need for making it public? |
Member
Author
|
Yes, it is a return value of a public function in #2067 ( |
MarcelKoch
force-pushed
the
1888/public-temporary-conversion
branch
from
August 18, 2026 14:37
d5dec4d to
a7ccae7
Compare
MarcelKoch
force-pushed
the
1888/precision-handling
branch
from
August 18, 2026 14:37
cb39513 to
8e4015d
Compare
MarcelKoch
force-pushed
the
1888/public-temporary-conversion
branch
from
August 18, 2026 14:57
a7ccae7 to
9d3847a
Compare
MarcelKoch
force-pushed
the
1888/precision-handling
branch
from
August 18, 2026 14:57
8e4015d to
55551dd
Compare
MarcelKoch
added
1:ST:ready-for-review
MarcelKoch
force-pushed
the
1888/public-temporary-conversion
branch
from
August 19, 2026 12:38
9d3847a to
c410e89
Compare
MarcelKoch
force-pushed
the
1888/precision-handling
branch
from
August 19, 2026 12:38
55551dd to
560109c
Compare
Signed-off-by: Marcel Koch <marcel.koch@kit.edu>
MarcelKoch
force-pushed
the
1888/precision-handling
branch
from
August 19, 2026 12:56
560109c to
ebe527a
Compare
MarcelKoch
force-pushed
the
1888/public-temporary-conversion
branch
from
August 19, 2026 12:56
c410e89 to
8445ef7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
temporary_conversionclass public. It also adds new create functions for:Later the original
temporary_conversion::create<T1, T2, T3, ...>(op)will be removed, since it will not be used anymore.