Scale corrected ir smoother - #2036
Draft
greole wants to merge 7 commits into
Draft
Conversation
ginkgo-bot
added
reg:build
greole
force-pushed
the
scaleCorrectionIR
branch
from
June 23, 2026 11:56
8770bc8 to
9a68ea5
Compare
yhmtsai
reviewed
Jun 23, 2026
yhmtsai
left a comment
yhmtsai
left a comment
Member
There was a problem hiding this comment.
miss ir.hpp change, should remove scale-correction-mg-solver binary, need to add test
greole
force-pushed
the
scaleCorrectionIR
branch
from
June 23, 2026 14:39
6861d33 to
6eaf738
Compare
yhmtsai
requested changes
Jun 24, 2026
| std::shared_ptr<const LinOp>(dense_b, [](const LinOp*) {}), dense_x, | ||
| residual_ptr); | ||
|
|
||
| // Matches the OpenFOAM GAMGSolver::scale function: |
Member
There was a problem hiding this comment.
do you also have paper reference?
Comment on lines
+259
to
+260
| if (const auto* de = | ||
| dynamic_cast<const DiagonalExtractable<ValueType>*>(local_A)) { |
Member
There was a problem hiding this comment.
this only check whether the diagonal can be extracted.
but it might have some zero in the diagonal
Member
There was a problem hiding this comment.
can this be replaced by Jacobi-IR with 1 iteration?
| // then accumulate into x. | ||
| apply_scale_correction(inner_solution, residual_ptr); | ||
| } | ||
| dense_x->add_scaled(relaxation_factor_, inner_solution); |
Member
There was a problem hiding this comment.
should relaxation_factor be used together with the scale correction?
| * OpenFOAM never scales x directly, so mode 1 has no OpenFOAM | ||
| * equivalent. | ||
| */ | ||
| int GKO_FACTORY_PARAMETER_SCALAR(scale_correction, 0); |
Member
There was a problem hiding this comment.
maybe have a tag?
ir_method::richardson, backward, forward.
Is mode 1 used in some cases?
Member
There was a problem hiding this comment.
+1 for tag.
It could be extended to use the approach in https://dl.acm.org/doi/full/10.1145/3712285.3759807
greole
marked this pull request as draft
June 26, 2026 08:21
greole
force-pushed
the
scaleCorrectionIR
branch
from
June 27, 2026 06:12
8f86851 to
5abc13f
Compare
greole
force-pushed
the
scaleCorrectionIR
branch
from
July 22, 2026 13:39
5dad4aa to
9bbb7d1
Compare
The IR-based scale correction (Ir scale_correction = none/forward/backward,
the scale_correction_mode enum) was superseded by the multigrid-level
scale_correction. The champion case drives scale correction entirely from
solver::Multigrid (scale_correction=true) and sets its Ir smoothers to
scale_correction=none, so the IR compute path is never exercised.
Revert ir.{hpp,cpp}, the scale_correction_mode enum (solver_base.hpp) and its
config parsing (config_helper.hpp) to develop, and drop the IR-backward
example. The multigrid scale_correction / scale_correction_pre_smooth feature
is unaffected.
develop moved copy_from from LinOp to Cloneable; the pre-smooth scale block still used r->copy_from(b). Use as<Cloneable>(r)->copy_from( as<Cloneable>(b)) to match the post-smooth block and develop.
greole
force-pushed
the
scaleCorrectionIR
branch
from
July 22, 2026 15:38
233efb9 to
4251932
Compare
Member
|
Error: The following files need to be formatted: You can find a formatting patch under Artifacts here or run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a scale corrected IR smoother which aims to improve convergence.