Skip to content

Make wrk2 arm compatible - #110

Open
tbbharaj wants to merge 1 commit into
giltene:masterfrom
tbbharaj:wrk2-a64-support
Open

Make wrk2 arm compatible#110
tbbharaj wants to merge 1 commit into
giltene:masterfrom
tbbharaj:wrk2-a64-support

Conversation

@tbbharaj

Copy link
Copy Markdown

Trying to compile wrk2 on arm, generates following error:

lj_arch.h:279:2: error: #error "No target architecture defined"
 #error "No target architecture defined"

Upgraded LuaJIT to 2.1 to make wrk2 arm compatible.
Also added few minor changes to hdr_histogram.c script.c wrk.c to make it compile

@tbbharaj
tbbharaj force-pushed the wrk2-a64-support branch from 8accadc to 60490fd Compare May 13, 2021 16:25
@tbbharaj tbbharaj changed the title Make wrk2 aarch64 compatible Make wrk2 arm compatible May 13, 2021
@tbbharaj
tbbharaj marked this pull request as ready for review May 13, 2021 16:44
@tbbharaj

Copy link
Copy Markdown
Author

Wanted to followup on this PR to get wrk2 compiled on aarch64

@raguiar9080

Copy link
Copy Markdown

@tbbharaj Is there a way to get this branch installed locally? I'm a bit of a noob regarding brew but I saw no way to do it.
Appreciate the time, thanks for any help 👍

@tbbharaj

tbbharaj commented Oct 12, 2021

Copy link
Copy Markdown
Author

@tbbharaj Is there a way to get this branch installed locally? I'm a bit of a noob regarding brew but I saw no way to do it. Appreciate the time, thanks for any help 👍

Are you able to clone this repo/branch?

@raguiar9080

Copy link
Copy Markdown

@tbbharaj Is there a way to get this branch installed locally? I'm a bit of a noob regarding brew but I saw no way to do it. Appreciate the time, thanks for any help 👍

Are you able to clone this repo/branch?

Just to give you a point of situation, I can and did clone the branch, but then ran into several issues while trying to build it (openssl include files followed by a malformed Mach-o file).

I just went and ran a linux container to install normally since my purpose is just perform some tests. Thanks for the help 👍

@tbbharaj

Copy link
Copy Markdown
Author

Wanted to followup on this PR. Happy to address any feedbacks/reviews

@tbbharaj

tbbharaj commented Jan 21, 2022

Copy link
Copy Markdown
Author

Wanted to followup on this PR, would love to see wrk2 supporting arm

@raguiar9080

Copy link
Copy Markdown

I've since moved away from this. I solved my issue by simply creating a docker container and doing things from the inside so I can't really provide any further feedback.

Best of luck 🙏

@sebpop

sebpop commented Mar 30, 2022

Copy link
Copy Markdown

Hi,
who can review and merge this patch?
With this patch I can build and use wrk2 on arm64.

Thanks!

@orefalo

orefalo commented Apr 14, 2022

Copy link
Copy Markdown

thank you.
sorry to ask, I am a newbie.
I see no configure script.
and when I run make, i get

Apple clang version 13.1.6 (clang-1316.0.21.2.3)
Target: arm64-apple-darwin21.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

i did brew install gcc but then it's not picked up

@orefalo

orefalo commented Jun 21, 2022

Copy link
Copy Markdown

found this guy https://github.com/AppsFlyer/wrk3

@AGSaidi

AGSaidi commented Jul 16, 2022

Copy link
Copy Markdown

any hope to get this reviewed and merged?

@outsinre

Copy link
Copy Markdown

For those, who would like to run wrk2 on Apple M1, please refer to https://github.com/outsinre/homebrew-wrk2.

@odidev

odidev commented Sep 21, 2022

Copy link
Copy Markdown

Team, Can we please merge this PR to make wrk2 compatible with arm64.

@RamaMalladiGH

Copy link
Copy Markdown

Checking again... Can this patch be merged? Thanks.

@orefalo

orefalo commented May 15, 2023

Copy link
Copy Markdown

I switched to oha - https://github.com/hatoo/oha

recommended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants