New cork options "-first" and "-second" to produce A U (A^B) and B U (A^B) - #32
Open
fangq wants to merge 7 commits into
Open
New cork options "-first" and "-second" to produce A U (A^B) and B U (A^B)#32fangq wants to merge 7 commits into
fangq wants to merge 7 commits into
Conversation
…iangulation Triangle (triangle.c/triangle.h) is free for personal use only and may not be redistributed as part of a commercial or open-source product, which prevented bundling cork into iso2mesh. Replace it with the header-only CDT library v1.4.5 (https://github.com/artem-ogre/CDT), licensed under the Mozilla Public License 2.0; its bundled robust geometric predicates are BSD 3-Clause. triangulatePolygon() in mesh.isct.tpp now performs the 2d constrained Delaunay triangulation via CDT: insert projected vertices and constraint edges, then eraseOuterTriangles() to discard triangles outside the closed boundary loop. eraseOuterTriangles (rather than eraseSuperTriangle) is required because quantized intersection points may fall slightly outside the original triangle, and keeping the full convex hull produces overlapping sliver triangles. CDT outputs CCW triangles indexed in insertion order, matching Triangle's conventions, so no other changes are needed. Verified against the Triangle-based build: -resolve, -isct, -union, -diff and -xor on the sample meshes (plus a rotated self-overlap stress test) produce identical vertex/face/edge counts, watertight manifold output, matching volumes, and a clean valgrind run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two changes were found necessary in order to use cork in my project:
I also included the modified cork binary in my mesh generator project iso2mesh to replace the outdated libgts boolean operator.
fangq/iso2mesh@2acea45