macOS: avoid holding SurfaceView when sending notifications - #13787
Closed
bo2themax wants to merge 1 commit into
Closed
macOS: avoid holding SurfaceView when sending notifications#13787bo2themax wants to merge 1 commit into
bo2themax wants to merge 1 commit into
Conversation
jparise
reviewed
Aug 13, 2026
| // We need to keep track of this notification so we can remove it | ||
| // under certain circumstances | ||
| notificationIdentifiers.insert(uuid) | ||
| self?.notificationIdentifiers.insert(uuid) |
Contributor
There was a problem hiding this comment.
Maybe guard let self ... here to simplify the rest of this block's calling patterns? Everything afterward is dependent on self being available.
Member
Author
There was a problem hiding this comment.
We still need to remove the notification using uuid 3s later. I would imagine at least copy the check twice馃檲
Contributor
There was a problem hiding this comment.
If that's the case, then isn't the if self?.focused == true condition going to fail and prevent the UUID-based removal from running anyway?
Member
Author
There was a problem hiding this comment.
Oh yeah, you are right
mitchellh
added a commit
that referenced
this pull request
Aug 14, 2026
We shouldn't hold a closing surface view when sending notifications and waiting to dismiss that notification. This happens rarely, but it's the right thing to do. ### AI Disclosure Found by Claude when judging other branches, I applied the changes myself. > Forgot that after force pushing, you can't reopen #13787 馃, linking it here for the review history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't hold a closing surface view when sending notifications. This happens rarely, but it's the right thing to do.
AI Disclosure
Found by Claude when judging other branches, I applied the changes myself.