gtk: update AdwStyleManager on configuration reload - #13693
Closed
gotenksIN wants to merge 1 commit into
Closed
Conversation
Ensure that changes to window-theme or background color during runtime configuration reload update AdwStyleManager's color scheme.
Contributor
|
Hi @gotenksIN, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
Member
|
!vouch |
Merged
ghostty-vouch Bot
added a commit
that referenced
this pull request
Aug 8, 2026
Triggered by [comment](#13693 (comment)) from @tristan957. Vouch: @gotenksIN Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
|
The code looks good. I'd like to take some time to reproduce the issue. |
Member
|
A similar fix was added to #13605 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
AdwStyleManagerwhen Ghostty reloads its configuration.Ghostty previously applied the GTK color scheme only during application startup. Changing
window-themeor the terminal background color during a configuration reload left the GTK titlebar appearance unchanged until restart.This change extracts style updates into
updateStyleManager()and calls it during configuration reloads. The existingwindow-theme = systemmapping remains unchanged.Fixes #2767.
Related to #2781.
Testing:
window-theme = darkand Catppuccin Frappe.window-theme = lightand Catppuccin Latte.SIGUSR2.zig build.This code was written with assistance from GPT 5.6 Sol and manually reviewed.