apprt: move command palette support check into zig - #13672
Open
bo2themax wants to merge 1 commit into
Open
Conversation
bo2themax
force-pushed
the
push-59c9e27f
branch
from
August 6, 2026 17:13
a2e082f to
dd33faa
Compare
jcollie
approved these changes
Aug 6, 2026
bo2themax
force-pushed
the
push-59c9e27f
branch
5 times, most recently
from
August 13, 2026 15:23
d0ffa99 to
99154c7
Compare
Whether a command palette entry does anything is a property of the apprt that receives the action, but both apps kept their own hand-maintained list and both had drifted. `ghostty_command_s` now carries `supported`, filled from a table that each apprt owns: * macOS, iOS: src/apprt/embedded/command.zig * GTK: src/apprt/gtk/command.zig Fixes the entries both lists were missing: * macOS: show_on_screen_keyboard, move_tab_to_new_window * GTK: toggle_background_opacity
bo2themax
force-pushed
the
push-59c9e27f
branch
from
August 14, 2026 06:59
99154c7 to
7b6b295
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised during conversation in #10999.
Added two command files for macOS and GTK to check whether an action is supported. So new action added in the future will have to update these two to avoid drifting.
Fixes the entries both lists were missing:
show_on_screen_keyboard,move_tab_to_new_windowtoggle_background_opacity,toggle_visibilityAI Disclosure
Claude implemented this, i reviewed and tested on macOS, gtk part looks simple enough.