Skip to content

Support wisp v2 - #5

Merged
ghivert merged 3 commits into
ghivert:mainfrom
JonasGruenwald:main
Sep 11, 2025
Merged

ghivert merged 3 commits into
ghivert:mainfrom
JonasGruenwald:main

Conversation

@JonasGruenwald

Copy link
Copy Markdown
Contributor

@ghivert hi, thanks for your work on this package, I'd love to use it with wisp 2.0 :)

@ghivert

ghivert commented Sep 11, 2025 •

Copy link
Copy Markdown
Owner

Hi! Thanks for your contribution! I'd like to avoid breaking compatibility with wisp 1. Could you, instead of returning wisp.Text(""), return wisp.Bytes()? That would allow to relax the dependencies of cors_builder, and Wisp requirements could be >= 1.0.0 and < 3.0.0. That way, we could make sure to not split the codebase, and let people upgrade cors_builder and wisp each at their own rhythm.

@JonasGruenwald

Copy link
Copy Markdown
Contributor Author

@ghivert makes a lot of sense! I've made that change.

@ghivert

ghivert commented Sep 11, 2025

Copy link
Copy Markdown
Owner

Thanks! Can you please update the tests and the CHANGELOG.md?

@JonasGruenwald

Copy link
Copy Markdown
Contributor Author

Sure! I don't think anything should change for the tests, but it appears that the Gleam version used in CI is too old, I've updated that and the changelog.

@ghivert

ghivert commented Sep 11, 2025

Copy link
Copy Markdown
Owner

Thank you!

@ghivert
ghivert merged commit 16517e8 into ghivert:main Sep 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants