Clarify that supported PR actions are any valid Github PR actions - #286
Closed
cosmith wants to merge 1 commit into
Closed
Clarify that supported PR actions are any valid Github PR actions#286cosmith wants to merge 1 commit into
cosmith wants to merge 1 commit into
Conversation
Member
|
thanks! |
Contributor
dcramer
added a commit
that referenced
this pull request
Aug 4, 2026
## Summary Skill docs still listed only `opened` / `synchronize` / `reopened` / `closed` for `pull_request` actions. Config already accepts arbitrary action strings (`z.array(z.string())`) and matches with `includes(context.action)`, so `ready_for_review` and other GitHub PR webhook actions already work. ## Changes - Update `skills/warden/references/config-schema.md` - Update `skills/warden/references/configuration.md` (same stale list) ## Why not #286 Supersedes [#286](#286). That was the same docs fix from a fork (`cosmith:patch-1`) where no GitHub Actions workflows ever ran on the head SHA — only Vercel auth failure + external checks — so there was nothing to re-run. This internal branch gets real CI. ## Checks - Docs-only; no code/runtime change - CI on this PR is the validation <!-- junior-request-attribution:start --> Requested by **David Cramer**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0ACFA5JBDX%3A1785871445.612169 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC0ACFA5JBDX%3A1785871445.612169) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0ACFA5JBDX%3A1785871445.612169/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: David Cramer <david@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thanks for this tool!
While setting it up I had a Codex review incorrectly flag
ready_for_reviewas unsupported. I checked the source and tested it and it works fine, so my proposal is to soften the skill wording a bit to make it clear that any Github PR action from this list is valid.