fix(schema): Allow missing projectSlugs/issueIds in AgenticOnboardingRunSchema - #1248
Open
sentry[bot] wants to merge 1 commit into
Open
fix(schema): Allow missing projectSlugs/issueIds in AgenticOnboardingRunSchema#1248sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue MCP-SERVER-G77, a ZodError occurring during the validation of
AgenticOnboardingRunSchemainSentryApiService.updateAgenticOnboardingStatus.The root cause was that the
projectSlugsandissueIdsfields inAgenticOnboardingRunSchemawere defined using.nullable(), which only acceptsnullvalues. However, the backend API would sometimes omit these fields entirely when they had no value, resulting in them beingundefinedin the received data. Zod's.nullable()does not considerundefinedvalid, leading to validation failures.The fix involves changing
.nullable()to.nullish()for bothprojectSlugsandissueIdsinpackages/mcp-core/src/api-client/schema.ts. This modification allows the schema to correctly validate bothnullandundefinedvalues for these fields, aligning with the backend's behavior. The existing.transform((v) => v ?? [])will continue to correctly default bothnullandundefinedto an empty array.Fixes MCP-SERVER-G77