test(e2e): Assert error events link to their request transaction - #23470
Merged
Conversation
For the Node express/fastify/koa "Sends correct error event" tests, also fetch the request's transaction and assert the error shares its trace_id and is anchored to a span belonging to that transaction (its root span or a child), instead of only matching the trace context against loose regexes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
August 21, 2026 09:58
s1gr1d
approved these changes
Aug 24, 2026
JPeer264
pushed a commit
that referenced
this pull request
Aug 25, 2026
) For the Node express/fastify/koa "Sends correct error event" tests, also fetch the request's transaction and assert the error shares its trace_id and is anchored to a span belonging to that transaction (its root span or a child), instead of only matching the trace context against loose regexes. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Node express/fastify/koa "Sends correct error event" tests, also fetch the request's transaction and assert the error shares its trace_id and is anchored to a span belonging to that transaction (its root span or a child), instead of only matching the trace context against loose regexes.