feat: Emit low-cardinality pageload span names when streaming spans - #23424
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1a7dc4f. Configure here.
RulaKhaled
reviewed
Aug 18, 2026
RulaKhaled
left a comment
RulaKhaled
left a comment
Collaborator
There was a problem hiding this comment.
Looks solid overall 👏 left two questions regarding static routes, and the new e2e assertions
nicohrubec
reviewed
Aug 24, 2026
The streaming E2E specs asserted a `url.pathname` attribute that no SDK code sets. Pageload spans carry `url.path`, set by `browserTracingIntegration` when it creates the route span, so these assertions could never match. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
marked this pull request as ready for review
August 24, 2026 09:19
Lms24
requested review from
chargome,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
August 24, 2026 09:19
JPeer264
pushed a commit
that referenced
this pull request
Aug 25, 2026
…23424) This PR adjusts all `sentry.op: 'pageload'` spans to only emit low cardinality span names if span streaming is enabled. Concretely, for pageload spans, this means that we want to never set a raw URL as a span name, which was the current fallback for transaction-based span names. Instead, we now fall back to a static `"Pageload"` span name. The new low-cardinality pageload span names now adhere to the rules set in [conventions](https://getsentry.github.io/sentry-conventions/names/#browser-pageload). ref #22350 --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts all
sentry.op: 'pageload'spans to only emit low cardinality span names if span streaming is enabled.Concretely, for pageload spans, this means that we want to never set a raw URL as a span name, which was the current fallback for transaction-based span names. Instead, we now fall back to a static
"Pageload"span name.The new low-cardinality pageload span names now adhere to the rules set in conventions.
ref #22350