Move Cookbook Tests to Subdirectory - #7281
Conversation
fc5cbe3 to
26977ee
Compare
26977ee to
5bbecde
Compare
|
I just wanted to comment that #7158 is almost ready to merge and will likely create conflicts with this PR. Since #7158 has been in preparation for a while and touches a lot more tests than this PR I would like to merge it first. Afterwards this needs to be rebased and conflicts resolved (it is just a single line in the tests .prms that is different). |
4e26ad6 to
0df9e43
Compare
|
/rebuild |
gassmoeller
left a comment
There was a problem hiding this comment.
Thanks again for getting this started. Looks generally fine, except for the tests I marked. Maybe the refer to cookbooks and it is just not obvious from the name, in that case leave them in this PR. But if they are not, they should probably stay in the main directory.
|
@gassmoeller Thanks for looking thoroughly looking through this, I've looked at the .prm's for the tests that you asked about and they all include .prm's from cookbooks, which is definitely why they got sorted there initially. You bring up a good point though, an include statement doesn't mean that it is "testing" the cookbook. This is clearly true for the |
|
After going through more thoroughly, there is seemingly no test for |
|
Yes some cookbooks dont have tests, we only started asking for tests later. That is alright, we can add tests for them eventually. And it will be easier with this PR since now we have a list. Could you open an issue with the list of cookooks that dont have tests? Maybe we can use that in the tutorial of next years hackathon. |
|
@gassmoeller I opened two issues, one for the missing cookbooks and another for the missing benchmarks! Once the tests pass I'll rebase and hopefully these will be good to go |
e33c660 to
539d7e9
Compare
Move tests related to cookbooks into the cookbooks subdirectory.
If yes, please describe your usage of AI models in the creation of this pull request
AI helped identify tests to move