Skip to content

Move Cookbook Tests to Subdirectory - #7281

Open
danieldouglas92 wants to merge 2 commits into
geodynamics:mainfrom
danieldouglas92:cookbook_tests
Open

Move Cookbook Tests to Subdirectory#7281
danieldouglas92 wants to merge 2 commits into
geodynamics:mainfrom
danieldouglas92:cookbook_tests

Conversation

@danieldouglas92

Copy link
Copy Markdown
Contributor

Move tests related to cookbooks into the cookbooks subdirectory.

  • I followed the AI Policy:
    • Significant parts of this PR were written by AI (please add a sentence below).
    • AI has not been used in significant ways.

If yes, please describe your usage of AI models in the creation of this pull request
AI helped identify tests to move

@danieldouglas92

Copy link
Copy Markdown
Contributor Author

Based on my comment in #7282 I've removed the bunge_cookbook from the cookbooks tests subdirectory for now.

Once this PR and #7282 I'll move more tests. I suspect that trying to do it all at once will end up with multiple conflicts where the same tests gets sorted into different subdirectories.

@gassmoeller

Copy link
Copy Markdown
Member

I just wanted to comment that #7158 is almost ready to merge and will likely create conflicts with this PR. Since #7158 has been in preparation for a while and touches a lot more tests than this PR I would like to merge it first. Afterwards this needs to be rebased and conflicts resolved (it is just a single line in the tests .prms that is different).

@danieldouglas92
danieldouglas92 force-pushed the cookbook_tests branch 4 times, most recently from 4e26ad6 to 0df9e43 Compare August 7, 2026 18:40
@danieldouglas92

Copy link
Copy Markdown
Contributor Author

/rebuild

@gassmoeller gassmoeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for getting this started. Looks generally fine, except for the tests I marked. Maybe the refer to cookbooks and it is just not obvious from the name, in that case leave them in this PR. But if they are not, they should probably stay in the main directory.

Comment thread tests/cookbooks/interface_weakening/statistics
Comment thread tests/cookbooks/prescribed_solution_post_process_comp/screen-output
Comment thread tests/cookbooks/refinement_nonadiabatic_temperature/screen-output
Comment thread tests/cookbooks/visualization_higher_order_output/screen-output
@danieldouglas92

danieldouglas92 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

@gassmoeller Thanks for looking thoroughly looking through this, I've looked at the .prm's for the tests that you asked about and they all include .prm's from cookbooks, which is definitely why they got sorted there initially. You bring up a good point though, an include statement doesn't mean that it is "testing" the cookbook.

This is clearly true for theinterface_weakening test, which is testing the new weakening mechanism that Ryan added at the hackathon (entirely unrelated to continental_extension) but it just so happens to use the continental_extension cookbook as a base. I'll take a closer look at the other ones and try to decide if they are actually testing the cookbook or not and move them accordingly.

@danieldouglas92

danieldouglas92 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

After going through more thoroughly, there is seemingly no test for crustal_deformation_2D, finite_strain, free_surface, free_surface_with_crust, geomIO, lower_crustal_flow, platelike-boundary, plume_2D_chunk, prescribed_velocity_ascii_data, van-keken-vof, and all of the shell cookbooks (shell-simple 2D/3D, shell 2D smoothing and shell 3D postprocessing).

@gassmoeller

Copy link
Copy Markdown
Member

Yes some cookbooks dont have tests, we only started asking for tests later. That is alright, we can add tests for them eventually. And it will be easier with this PR since now we have a list. Could you open an issue with the list of cookooks that dont have tests? Maybe we can use that in the tutorial of next years hackathon.

@danieldouglas92 danieldouglas92 mentioned this pull request Aug 8, 2026
14 tasks
@danieldouglas92

Copy link
Copy Markdown
Contributor Author

@gassmoeller I opened two issues, one for the missing cookbooks and another for the missing benchmarks! Once the tests pass I'll rebase and hopefully these will be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants