Skip to content

test: random particle generator serialization - #7244

Open
tjhei wants to merge 1 commit into
geodynamics:mainfrom
tjhei:test-checkpoint-particle-random
Open

test: random particle generator serialization#7244
tjhei wants to merge 1 commit into
geodynamics:mainfrom
tjhei:test-checkpoint-particle-random

Conversation

@tjhei

@tjhei tjhei commented Jul 30, 2026

Copy link
Copy Markdown
Member

part of #7099 because checkpointing is broken due to random number generators. This test fails without a fix such as proposed #7099 or #7240

Test written by AI.

FYI @bangerth

@bangerth

Copy link
Copy Markdown
Contributor

Let's hold off on this then for now.

@tjhei
tjhei force-pushed the test-checkpoint-particle-random branch from a525184 to 94d017c Compare July 30, 2026 13:02
@tjhei

tjhei commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

waiting for #7245

@bangerth

Copy link
Copy Markdown
Contributor

Actually, to the successor of #7245 that isn't written yet.

@bangerth

bangerth commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Can you rebase this now?

@tjhei
tjhei force-pushed the test-checkpoint-particle-random branch from 94d017c to 2b7a6f0 Compare August 8, 2026 21:46
@tjhei
tjhei marked this pull request as ready for review August 8, 2026 21:47
@tjhei

tjhei commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

Rebased. Let's see what happens.

@bangerth

bangerth commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Well, it fails:

----------------
##5       <== cd output-checkpoint_13_particle_generator_random  rm -rf output1.tmp  (cat /ssd/aspect-git8/tests/checkpoint_13_particle_generator_random.prm    echo 'set Output directory = output1.tmp' ) | env -i PATH="$PATH" mpirun --oversubscribe -np 2 ../../aspect -- > /dev/null
##5       ==> cd output-checkpoint_13_particle_generator_random  rm -rf output1.tmp  (cat $ASPECT_SOURCE_DIR/tests/checkpoint_13_particle_generator_random.prm    echo 'set Output directory = output1.tmp' ) | env -i PATH="$PATH" mpirun --oversubscribe -np 2 ../../aspect -- > /dev/null

##5       #:7   <== /ssd/aspect-git8/tests/checkpoint_13_particle_generator_random.prm
##5       #:7   ==> $ASPECT_SOURCE_DIR/tests/checkpoint_13_particle_generator_random.prm
@                                                     @@
----------------
##6       <== Executing the following command:
##6       ==> mpirun has detected an attempt to run as root.

##6       #:1   <== Executing
##6       #:1   ==> mpirun
@                                                     @@
##6       #:2   <== the
##6       #:2   ==> has
@                                                     @@
##6       #:3   <== following
##6       #:3   ==> detected
@                                                     @@
##6       #:4   <== command
##6       #:4   ==> an
@                                                     @@
##6             <==
##6       #>5   ==> attempt to run as root.
@ Line 6 in file "/__w/aspect/aspect/build/tests/output-checkpoint_13_particle_generator_random/screen-output.cmp.notime" is shorter than expected!
----------------
##7       <== cd output-checkpoint_13_particle_generator_random   rm -rf output2.tmp  mkdir output2.tmp   mv output1.tmp/restart output2.tmp/
##7       ==> 

##7       #>1   <== cd output-checkpoint_13_particle_generator_random   rm -rf output2.tmp  mkdir output2.tmp   mv output1.tmp/restart output2.tmp/
##7             ==>
@ Line 7 in file "/__w/aspect/aspect/build/tests/output-checkpoint_13_particle_generator_random/screen-output.notime" is shorter than expected!
----------------
##8       <== * now resuming:
##8       ==> Running as root is *strongly* discouraged as any mistake (e.g., in

##8       #:1   <== *
##8       #:1   ==> Running
@                                                     @@
##8       #:2   <== now
##8       #:2   ==> as
@                                                     @@
##8       #:3   <== resuming
##8       #:3   ==> root
@                                                     @@
##8             <==
##8       #>4   ==> is *strongly* discouraged as any mistake (e.g., in
@ Line 8 in file "/__w/aspect/aspect/build/tests/output-checkpoint_13_particle_generator_random/screen-output.cmp.notime" is shorter than expected!
----------------
ninja: build stopped: subcommand failed.

CMake Error at /__w/aspect/aspect/tests/run_test.cmake:14 (message):
  *** Test aborted.

@tjhei
tjhei force-pushed the test-checkpoint-particle-random branch 4 times, most recently from c0fec73 to a1a0574 Compare August 10, 2026 13:11
@tjhei
tjhei force-pushed the test-checkpoint-particle-random branch from a1a0574 to 7469b1d Compare August 10, 2026 14:45
@tjhei

tjhei commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

Alright, I got it to work. It is worth noting that this is seems to be the first checkpointing test with >1 MPI rank. @bangerth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants