Boundary composition plugin based on mesh deformation output - #7225
Open
anne-glerum wants to merge 15 commits into
Open
Boundary composition plugin based on mesh deformation output#7225anne-glerum wants to merge 15 commits into
anne-glerum wants to merge 15 commits into
Conversation
tjhei
reviewed
Jul 30, 2026
tjhei
reviewed
Jul 30, 2026
tjhei
approved these changes
Jul 30, 2026
Member
|
Hey @anne-glerum , do you need help with this? |
anne-glerum
force-pushed
the
mesh_def_boundary_composition
branch
from
August 18, 2026 11:20
5ac61d1 to
fd2ab27
Compare
anne-glerum
changed the title
Contributor
Author
|
Hi @tjhei I've been on holiday since the hack (until the end of this week). That said, I think this is now ready for a real review :) |
Member
|
That sounds lovely. 😀 |
tjhei
approved these changes
Aug 18, 2026
tjhei
left a comment
tjhei
left a comment
Member
There was a problem hiding this comment.
Looks good to me. One question though.
| const Point<dim> &/*position*/, | ||
| const unsigned int /*compositional_field*/) const | ||
| { | ||
| AssertThrow(false, ExcMessage("The boundary_composition function is not implemented for this mesh deformation plugin.")); |
Member
There was a problem hiding this comment.
Should the default be zero or an exception? I think in the documentation you claim 0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncleaned MWE to discuss with @tjhei only for now.
For all pull requests:
If yes, please describe your usage of AI models in the creation of this pull request
For new features/models or changes of existing features: