[128] Fix ReferenceError: weakly-referenced object no longer exists bug - #197
Open
Felipe-CdS wants to merge 2 commits into
Open
[128] Fix ReferenceError: weakly-referenced object no longer exists bug#197Felipe-CdS wants to merge 2 commits into
Felipe-CdS wants to merge 2 commits into
Conversation
Felipe-CdS
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #128.
This change makes
DataflowModelkeep a durabletrial_refalongside its weak trial proxy, allowing export_text() to reload the Trial if the original weakly-referenced object has already been garbage-collected. It also updates the default dependency graph mode from the stale simulation name tocoarseGrain.Adds a test covering dataflow export after the original Trial object dies.