Skip to content

Replace pkg_resources version lookup #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mirochill wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Replace pkg_resources version lookup #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/noworkflow/now/collection/prov_deployment/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@
from __future__ import (absolute_import, print_function,
division, unicode_literals)

import importlib
import importlib.metadata
import modulefinder
import os
import platform
import socket
import sys
import weakref
import getpass
import pkg_resources

from future.utils import viewitems, native_str
from future.builtins import map as cvmap
Expand Down Expand Up @@ -88,8 +87,7 @@ def get_version(self, module):

# Check package declared module version
try:
# ToDo: This is slow! Is there any alternative?
return pkg_resources.get_distribution(module_name).version
return importlib.metadata.version(module_name)
except Exception: # pylint: disable=broad-except
pass

Expand Down