Fix RSA decryption of binary data - #2678
Open
zhangli091011 wants to merge 1 commit into
Open
Conversation
Author
|
The CLA is complete, but the required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Treat RSA ciphertext and plaintext as raw bytes instead of UTF-8 strings. This prevents binary ciphertext from being corrupted before decryption and allows non-UTF-8 plaintext, such as decrypted symmetric keys, to flow into operations like To Hex.
Existing Issue
Closes #2436.
Screenshots
Not applicable; this is an operation data handling fix.
AI disclosure
OpenCode (gpt-5.6-sol) was used to investigate the issue, implement the fix, and add the regression test. I reviewed the diff and ran the full non-UI test suite.
Test Coverage
Added an RSA-OAEP/SHA-256 regression vector covering From Hex -> RSA Decrypt -> To Hex.