feat(cli): Conversion of modengine2.toml files to profiles - #861
Open
garyttierney wants to merge 1 commit into
Open
feat(cli): Conversion of modengine2.toml files to profiles#861garyttierney wants to merge 1 commit into
garyttierney wants to merge 1 commit into
Conversation
Signed-off-by: Gary Tierney <gary.tierney@fastmail.com>
Dasaav-dsv
reviewed
Aug 9, 2026
Collaborator
There was a problem hiding this comment.
Instead of making this specific profile version have public fields, imo it would be better to have a generalized builder that creates the newest profile version (with v2 support in mind), like the one on my profile v2 PR https://github.com/Dasaav-dsv/me3/edit/feat/profile-v2/crates/mod-protocol/src/profile/builder.rs?pr=/garyttierney/me3/pull/530
Collaborator
There was a problem hiding this comment.
Stylistic nit: I don't like the ModEngine2 prefix on all structs, think it's fine if only ModEngine2Config keeps it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
me3 profile convertcommand that can output an me3 file from an existingmodengine2.toml