Skip to content

Test the Julia GC integration with VALIDATE_MARKING in CI #6524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fingolfin wants to merge 1 commit into from
+11 −2
Closed

Test the Julia GC integration with VALIDATE_MARKING in CI #6524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/gapjl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ concurrency:

jobs:
test:
name: Julia ${{ matrix.julia-version }} - GAP.jl ${{ matrix.gapjl-version }} - ${{ matrix.os }}
name: Julia ${{ matrix.julia-version }} - GAP.jl ${{ matrix.gapjl-version }} - ${{ matrix.os }}${{ matrix.validate-marking && ' - VALIDATE_MARKING' || '' }}
runs-on: ${{ matrix.os }}
timeout-minutes: 40
continue-on-error: ${{ matrix.julia-version == 'nightly' }}
Expand All @@ -33,6 +33,8 @@ jobs:
- 'nightly'
os:
- ubuntu-latest
validate-marking:
- false
include:
# Add a few macOS jobs (the number we can run in parallel is limited)
- gapjl-version: 'latest-release'
Expand All @@ -41,6 +43,13 @@ jobs:
- gapjl-version: 'master'
julia-version: '1'
os: macOS-latest
# build the Julia GC integration with VALIDATE_MARKING, to detect
# invalid references during GC marking
# (see https://github.com/oscar-system/GAP.jl/issues/1364)
- gapjl-version: 'master'
julia-version: '1'
os: ubuntu-latest
validate-marking: true

steps:
- name: Checkout GAP
Expand Down Expand Up @@ -97,7 +106,7 @@ jobs:
make -j`nproc`
- name: "Override bundled GAP"
run: |
julia --project=$GAPJLPATH $GAPJLPATH/etc/setup_override_dir.jl /tmp/GAPROOT /tmp/gap_jll_override --enable-Werror
julia --project=$GAPJLPATH $GAPJLPATH/etc/setup_override_dir.jl /tmp/GAPROOT /tmp/gap_jll_override --enable-Werror ${{ matrix.validate-marking && '--validate-marking' || '' }}
- name: "Run tests"
run: |
julia --project=$GAPJLPATH $GAPJLPATH/etc/run_with_override.jl /tmp/gap_jll_override --depwarn=error -e "using Pkg; Pkg.test(\"GAP\")"
Loading