Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
121 commits
Select commit Hold shift + click to select a range
ed4c9a8
re-edited library files, adding NC
cdwensley May 20, 2026
1f6bbaf
added non-NC methods so that tests pass
cdwensley May 20, 2026
5b98560
adjust documentation in mapping.gd
cdwensley May 20, 2026
9fd6948
replace items deleted in error in alghom.gi
cdwensley May 21, 2026
8481a39
applied fix from stertooy
cdwensley May 21, 2026
a8e5012
minor correction
cdwensley May 21, 2026
168d917
another adjustment to bugfix test
cdwensley May 21, 2026
e61b7cb
PackageVariablesInfo: better support variadic functions (#6404)
fingolfin May 19, 2026
f496cda
kernel: strengthen vecgf2 and vec8bit validation, reject empty vector…
fingolfin May 21, 2026
fb67a5c
Document SemiSimpleType field restriction (#6408)
fingolfin May 22, 2026
36f7f08
Clarify IsomorphismPcGroup docs (#6405)
fingolfin May 22, 2026
7d9c9f0
Reformat and refactor StructureDescription code (#6403)
fingolfin May 22, 2026
1c6c7ff
Add new logo to banner (B&W) (#6357)
mtorpey May 23, 2026
707c955
Switch banner to fully compact mode
fingolfin May 23, 2026
8a57dea
Turn LoadPackageDocumentation into a unary function (#6411)
fingolfin May 26, 2026
b49098a
doc: describe OrbitStabilizer return value (closes #6324) (#6410)
mvanhorn May 26, 2026
2fd8c10
Run --bare testinstall test in CI (#6354)
fingolfin May 27, 2026
06bb20b
Prepare release notes for GAP 4.16.0 (#6414)
fingolfin May 27, 2026
f14734d
Start work on GAP 4.17
fingolfin May 27, 2026
9f5c520
emscripten: add Docker-based one-stop build and polish demo page (#6385)
ChrisJefferson Jun 1, 2026
9de742a
Update COPYRIGHT
fingolfin Jun 1, 2026
cb25fa7
Fix RingGeneralMappingByImages for non-SCRing (#6418)
fingolfin Jun 1, 2026
ac1d8e9
Update CHANGES.md
fingolfin Jun 1, 2026
9490b09
Normalize release archive permissions (#6420)
fingolfin Jun 1, 2026
8ae5f61
julia-gc: introduce DISABLE_STACK_SCAN (#6421)
fingolfin Jun 5, 2026
2485080
Miscellaneous kernel tweaks (#6422)
fingolfin Jun 6, 2026
77f8ab0
More kernel tweaks (#6428)
fingolfin Jun 6, 2026
f1710d2
kernel: remove `ErrorReturnObj`, `C_NEW_STRING` (#6415)
fingolfin Jun 6, 2026
871d4fc
Fix ConjugateGroup for matrix groups not defined over a field (#6425)
fingolfin Jun 6, 2026
834868e
kernel: improve `ErrorReturnVoid` break-loop message (#6416)
fingolfin Jun 8, 2026
dece204
kernel: refactor FuncPRINT_CURRENT_STATEMENT (#6424)
fingolfin Jun 8, 2026
4e09c08
Adjust when 'Stack trace:' message is printed (#6432)
fingolfin Jun 8, 2026
a124678
build(deps): bump codecov/codecov-action from 6 to 7 (#6430)
dependabot[bot] Jun 8, 2026
ba5ed0c
Adjust conway polynomial error message (#6433)
fingolfin Jun 9, 2026
5dcc98e
Widen declaration for many matrix related functions (#6095)
fingolfin Jun 9, 2026
51da696
Further unify messages before break loop (#6434)
fingolfin Jun 10, 2026
0ad351b
Remove dev/migratedoc.tex and doc/tut/migrat.xml (#6431)
fingolfin Jun 10, 2026
f7afbcc
Remove SingleCollector_CollectWordRunning (#6426)
fingolfin Jun 11, 2026
4fea974
kernel: cleanup CRC code (#6436)
fingolfin Jun 11, 2026
3cd543f
doc: fix typo (#6438)
fingolfin Jun 11, 2026
f49b3f8
replaced 'return []' by 'return fail'
cdwensley Jun 18, 2026
f3dd617
build(deps): bump actions/checkout from 6 to 7 (#6444)
dependabot[bot] Jun 23, 2026
8532737
Remove InfoData, make INFO_CLASSES readonly (#6443)
fingolfin Jun 23, 2026
16256d1
Move over changes to the GAP.jl-CI job (#6445)
lgoettgens Jun 24, 2026
bd1a466
Perfect groups data is licensed under GPL 2.0 or later (#6450)
Jul 1, 2026
29814ef
Add an argument check to `CodePcgs` (#6451)
ThomasBreuer Jul 1, 2026
19f7a2e
kernel: make FormatOutput handle %g with null pointer (#6446)
fingolfin Jul 1, 2026
d22a930
turn the global variable `RUN_IN_GGMBI` into a global option `Run_In_…
ThomasBreuer Jul 1, 2026
18001cd
Document the encoding used by CodePcGroup & PcGroupCode (#6441)
mvanhorn Jul 1, 2026
4a30040
re-edited library files, adding NC
cdwensley May 20, 2026
15f971e
Merge branch 'master' into preimrep2
ThomasBreuer Jul 6, 2026
ca8a6ca
removed unwanted .changed file
cdwensley Jul 6, 2026
59dd0ef
fix a ref in mapping.gd, line 980
cdwensley Jul 6, 2026
9c97dd2
Merge branch 'master' into preimrep2
cdwensley Jul 8, 2026
c6d4f4e
made changes suggested by Thomas
cdwensley Jul 8, 2026
4a39d24
made changes suggested by Thomas
cdwensley Jul 8, 2026
f28660d
made changes suggested by Thomas
cdwensley Jul 8, 2026
01360af
added many error messages and a few methods
cdwensley Jul 9, 2026
fc31d4e
added many error messages and a few methods
cdwensley Jul 9, 2026
cb7672c
Change deprecated RUN_IN_GGMBI to `fail` (#6458)
fingolfin Jul 13, 2026
8a364fe
Add `ChiefLength` (length of any chief series) (#6455)
ThomasBreuer Jul 14, 2026
181f489
re-edited library files, adding NC
cdwensley May 20, 2026
94a8ca6
kernel: improve `ErrorReturnVoid` break-loop message (#6416)
fingolfin Jun 8, 2026
3c72620
Adjust when 'Stack trace:' message is printed (#6432)
fingolfin Jun 8, 2026
5ed2b08
turn the global variable `RUN_IN_GGMBI` into a global option `Run_In_…
ThomasBreuer Jul 1, 2026
5bd2601
adjusted the documentation in 32.5
cdwensley Jul 9, 2026
93ab537
using Intersection(elms,Range(map)) in PreImagesSet
cdwensley Jul 15, 2026
510aae3
addition to tst/testinstall/mapphomo.tst
cdwensley Jul 15, 2026
4348a34
using Intersection(elms,Range(map)) in PreImagesSet
cdwensley Jul 15, 2026
8dcf46e
revise the documentation for PreImagesSet
cdwensley Jul 15, 2026
aa5a67c
revise the documentation for PreImagesSet
cdwensley Jul 15, 2026
5e7c1cf
Update lib/field.gi
cdwensley Jul 17, 2026
866331f
Update lib/fldabnum.gi
cdwensley Jul 17, 2026
bdab1a8
Update lib/ghom.gi
cdwensley Jul 17, 2026
0fadf64
Update lib/ghomfp.gi
cdwensley Jul 17, 2026
425e88f
Update lib/ghomperm.gi
cdwensley Jul 17, 2026
208dbcf
Update lib/mapprep.gi
cdwensley Jul 17, 2026
c187191
Update lib/mapprep.gi
cdwensley Jul 17, 2026
6b40948
Update lib/mapprep.gi
cdwensley Jul 17, 2026
58b8c93
Update lib/mapprep.gi
cdwensley Jul 17, 2026
a84b430
Update lib/mapprep.gi
cdwensley Jul 17, 2026
5df23f7
Update lib/ghomperm.gi
cdwensley Jul 17, 2026
76b5357
Update lib/ghomperm.gi
cdwensley Jul 17, 2026
d600804
Update lib/mapphomo.gi
cdwensley Jul 17, 2026
ed90c7a
Update lib/mapphomo.gi
cdwensley Jul 17, 2026
fee4027
Update lib/mapphomo.gi
cdwensley Jul 17, 2026
c76bae6
Update lib/mapphomo.gi
cdwensley Jul 17, 2026
275940a
Update lib/mapphomo.gi
cdwensley Jul 17, 2026
994ef08
Update lib/mapping.gi
cdwensley Jul 17, 2026
0adad7d
Update lib/mapping.gd
cdwensley Jul 17, 2026
648454f
Update lib/mapphomo.gi
cdwensley Jul 17, 2026
ff611b0
Update lib/mapping.gi
cdwensley Jul 17, 2026
5ccc37d
Update lib/mapping.gi
cdwensley Jul 17, 2026
a122e74
Update lib/mapping.gi
cdwensley Jul 17, 2026
994c6b2
query in mapprep.gi answered by Thomas
cdwensley Jul 17, 2026
93b86b0
Update lib/mapprep.gi
cdwensley Jul 20, 2026
fbb579f
adjusted the documentation in 32.5
cdwensley Jul 20, 2026
2d68eea
Fix `BaumClausenInfo` when the pcgs is not G-invariant (#6459)
ThomasBreuer Jul 16, 2026
e817c22
Automorphism cleanup (#6462)
hulpke Jul 17, 2026
5ddc87f
Add SpeedupDataPcHom (#6449)
hulpke Jul 18, 2026
1885aa5
Fix a bug that could lead to `ContainedConjugates` returning too many…
hulpke Jul 19, 2026
a4c85fc
FIX: solvable steps in FittingFree classes (#6466)
hulpke Jul 23, 2026
a24cbd5
FIX: Typos and grammatical errors in comments across Hulpke-authored …
hulpke Jul 23, 2026
58d546e
re-edited library files, adding NC
cdwensley May 20, 2026
836425e
kernel: improve `ErrorReturnVoid` break-loop message (#6416)
fingolfin Jun 8, 2026
e686be5
Further unify messages before break loop (#6434)
fingolfin Jun 10, 2026
eb1b3b7
Remove dev/migratedoc.tex and doc/tut/migrat.xml (#6431)
fingolfin Jun 10, 2026
bfcd6a2
turn the global variable `RUN_IN_GGMBI` into a global option `Run_In_…
ThomasBreuer Jul 1, 2026
dedd030
Merge branch 'master' into preimrep2
fingolfin Jul 23, 2026
f491120
New emscripten polish (#6439)
ChrisJefferson Jul 23, 2026
32b58b6
re-edited library files, adding NC
cdwensley May 20, 2026
87c75ac
fixing a manual reference (again)
cdwensley Jul 27, 2026
5e20028
remove PreImagesNC from lib/
cdwensley Jul 28, 2026
0ec5b91
remove PreImagesNC from lib/
cdwensley Jul 28, 2026
8a55094
PreImageElm now returns an error if elm not in the image of map
cdwensley Jul 28, 2026
57913ec
more edits to PreImages documentation
cdwensley Jul 29, 2026
c1762a4
more edits to PreImages documentation
cdwensley Jul 29, 2026
72e2135
Merge branch 'master' into preimrep2
fingolfin Aug 26, 2026
0db32c1
lib/schur.gi: restore PreImagesRepresentativeNC changes
fingolfin Aug 26, 2026
e3020db
cleanup
fingolfin Aug 26, 2026
2ad5aa9
Adjust GAP version
fingolfin Aug 26, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/algebra.gi
Original file line number Diff line number Diff line change
Expand Up @@ -3647,7 +3647,7 @@ InstallMethod( CentralIdempotentsOfAlgebra,

until k>Length(ideals);

id:= List( ids, e -> PreImagesRepresentative( hom, e ) );
id:= List( ids, e -> PreImagesRepresentativeNC( hom, e ) );

# Now we lift the idempotents to the big algebra `A'. The
# first idempotent is lifted as follows:
Expand Down
2 changes: 1 addition & 1 deletion lib/algfp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ InstallHandlingByNiceBasis( "IsFpAlgebraElementsSpace", rec(
if hom = fail then
TryNextMethod();
fi;
return PreImagesRepresentative( hom, r );
return PreImagesRepresentativeNC( hom, r );
end ) );


Expand Down
36 changes: 16 additions & 20 deletions lib/alghom.gi
Original file line number Diff line number Diff line change
Expand Up @@ -576,16 +576,29 @@ InstallMethod( ImagesRepresentative,

#############################################################################
##
#M PreImagesRepresentativeNC( <map>, <elm> ) . . . . . for algebra g.m.b.i.
#M PreImagesRepresentative( <map>, <elm> ) . . . . . . for algebra g.m.b.i.
##
InstallMethod( PreImagesRepresentativeNC,
"for algebra g.m.b.i., and element",
FamRangeEqFamElm,
[ IsGeneralMapping and IsAlgebraGeneralMappingByImagesDefaultRep,
IsObject ],
function( map, elm )
return PreImagesRepresentativeNC(
AsLeftModuleGeneralMappingByImages(map), elm );
end );

InstallMethod( PreImagesRepresentative,
"for algebra g.m.b.i., and element",
FamRangeEqFamElm,
[ IsGeneralMapping and IsAlgebraGeneralMappingByImagesDefaultRep,
IsObject ],
function( map, elm )
return PreImagesRepresentative( AsLeftModuleGeneralMappingByImages(map),
elm );
if not ( elm in Range( map ) ) then
return fail;
fi;
return PreImagesRepresentativeNC( map, elm );
end );


Expand Down Expand Up @@ -902,7 +915,7 @@ InstallMethod( ImagesRepresentative,

#############################################################################
##
#M PreImagesRepresentative( <ophom>, <mat> )
#M PreImagesRepresentativeNC( <ophom>, <mat> )
##
BindGlobal( "PreImagesRepresentativeOperationAlgebraHomomorphism", function( ophom, mat )
if not IsBound( ophom!.basisImage ) then
Expand All @@ -915,12 +928,6 @@ BindGlobal( "PreImagesRepresentativeOperationAlgebraHomomorphism", function( oph
return mat;
end );

InstallMethod( PreImagesRepresentative,
"for an operation algebra homomorphism, and an element",
FamRangeEqFamElm,
[ IsOperationAlgebraHomomorphismDefaultRep, IsMatrix ],
PreImagesRepresentativeOperationAlgebraHomomorphism );


#############################################################################
##
Expand Down Expand Up @@ -1074,17 +1081,6 @@ InstallMethod( ImagesRepresentative,
end );


#############################################################################
##
#M PreImagesRepresentative( <ophom>, <mat> )
##
InstallMethod( PreImagesRepresentative,
"for an alg. hom. from f. p. algebra, and an element",
FamRangeEqFamElm,
[ IsAlgebraHomomorphismFromFpRep, IsMatrix ],
PreImagesRepresentativeOperationAlgebraHomomorphism );


#############################################################################
##
#M OperationAlgebraHomomorphism( <A>, <basis>, <opr> )
Expand Down
38 changes: 26 additions & 12 deletions lib/alglie.gi
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ InstallMethod( LieUpperCentralSeries,
# under the natural homomorphism.
Add( S, C );
hom:= NaturalHomomorphismByIdeal( L, C );
C:= PreImages( hom, LieCentre( Range( hom ) ) );
C:= PreImagesNC( hom, LieCentre( Range( hom ) ) );
#T we would like to get ideals!
#T is it possible to teach the hom. that the preimage of an ideal is an ideal?

Expand Down Expand Up @@ -1706,7 +1706,7 @@ InstallMethod( LieSolvableRadical,
quo:= ImagesSource( hom );
r1:= LieSolvableRadical( quo );
B:= BasisVectors( Basis( r1 ) );
B:= List( B, x -> PreImagesRepresentative( hom, x ) );
B:= List( B, x -> PreImagesRepresentativeNC( hom, x ) );
Append( B, BasisVectors( Basis( n ) ) );

fi;
Expand Down Expand Up @@ -2092,7 +2092,7 @@ InstallMethod( DirectSumDecomposition,
SetRadicalOfAlgebra( Q, Subalgebra( Q, [ Zero( Q ) ] ) );

id:= List( CentralIdempotentsOfAlgebra( Q ),
x->PreImagesRepresentative(hom,x));
x->PreImagesRepresentativeNC(hom,x));

# Now we lift the idempotents to the big algebra `A'. The
# first idempotent is lifted as follows:
Expand Down Expand Up @@ -4017,9 +4017,10 @@ InstallMethod( ImagesRepresentative,

###########################################################################
##
#M PreImagesRepresentativeNC( f, x )
#M PreImagesRepresentative( f, x )
##
InstallMethod( PreImagesRepresentative,
InstallMethod( PreImagesRepresentativeNC,
"for Fp to SCA mapping, and element",
FamRangeEqFamElm,
[ IsFptoSCAMorphism, IsSCAlgebraObj ], 0,
Expand Down Expand Up @@ -4095,6 +4096,19 @@ InstallMethod( PreImagesRepresentative,

end);

InstallMethod( PreImagesRepresentative,
"for Fp to SCA mapping, and element",
FamRangeEqFamElm,
[ IsFptoSCAMorphism, IsSCAlgebraObj ], 0,

function( f, x )
if not ( x in Range( f ) ) then
return fail;
fi;
return PreImagesRepresentative( f, x );
Comment thread
fingolfin marked this conversation as resolved.
Outdated

end );

#############################################################################
##
#M Dimension( <FpL> )
Expand Down Expand Up @@ -5592,8 +5606,8 @@ InstallMethod( JenningsLieAlgebra,
T:= EmptySCTable( dim , Zero(F) , "antisymmetric" );
pimgs := [];
for i in [1..dim] do
a:= PreImagesRepresentative( Homs[pos[i]] ,
PreImagesRepresentative( hom_pcg[pos[i]], gens[i] ) );
a:= PreImagesRepresentativeNC( Homs[pos[i]] ,
PreImagesRepresentativeNC( hom_pcg[pos[i]], gens[i] ) );

# calculate the p-th power image of `a':

Expand All @@ -5610,8 +5624,8 @@ InstallMethod( JenningsLieAlgebra,
# Calculate the commutator [a,b], and map the result into
# the correct homogeneous component.

b:= PreImagesRepresentative( Homs[pos[j]],
PreImagesRepresentative( hom_pcg[pos[j]], gens[j] ));
b:= PreImagesRepresentativeNC( Homs[pos[j]],
PreImagesRepresentativeNC( hom_pcg[pos[j]], gens[j] ));
c:= Image( hom_pcg[pos[i] + pos[j]],
Image(Homs[pos[i] + pos[j]], a^-1*b^-1*a*b) );
e:= ExtRepOfObj(c);
Expand Down Expand Up @@ -5788,8 +5802,8 @@ InstallMethod( PCentralLieAlgebra,
T:= EmptySCTable( dim , Zero(F) , "antisymmetric" );
pimgs := [];
for i in [1..dim] do
a:= PreImagesRepresentative( Homs[pos[i]] ,
PreImagesRepresentative( hom_pcg[pos[i]], gens[i] ) );
a:= PreImagesRepresentativeNC( Homs[pos[i]] ,
PreImagesRepresentativeNC( hom_pcg[pos[i]], gens[i] ) );


# calculate the p-th power image of `a':
Expand All @@ -5807,8 +5821,8 @@ InstallMethod( PCentralLieAlgebra,
# Calculate the commutator [a,b], and map the result into
# the correct homogeneous component.

b:= PreImagesRepresentative( Homs[pos[j]],
PreImagesRepresentative( hom_pcg[pos[j]], gens[j] ));
b:= PreImagesRepresentativeNC( Homs[pos[j]],
PreImagesRepresentativeNC( hom_pcg[pos[j]], gens[j] ));
c:= Image( hom_pcg[pos[i] + pos[j]],
Image(Homs[pos[i] + pos[j]], a^-1*b^-1*a*b) );
e:= ExtRepOfObj(c);
Expand Down
8 changes: 4 additions & 4 deletions lib/algrep.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1212,24 +1212,24 @@ InstallMethod( NaturalHomomorphismBySubAlgebraModule,
if IsLeftAlgebraModuleElementCollection( V ) then
if IsRightAlgebraModuleElementCollection( V ) then
left_op:= function( x, v )
return ImagesRepresentative( f, x^PreImagesRepresentative( f, v ) );
return ImagesRepresentative( f, x^PreImagesRepresentativeNC( f, v ) );
end;
right_op:= function( v, x )
return ImagesRepresentative( f, PreImagesRepresentative( f, v )^x );
return ImagesRepresentative( f, PreImagesRepresentativeNC( f, v )^x );
end;
qmod:= BiAlgebraModule( LeftActingAlgebra( V ),
RightActingAlgebra( V ),
left_op, right_op, quot );
else
left_op:= function( x, v )
return ImagesRepresentative( f, x^PreImagesRepresentative( f, v ) );
return ImagesRepresentative( f, x^PreImagesRepresentativeNC( f, v ) );
end;
qmod:= LeftAlgebraModule( LeftActingAlgebra( V ),
left_op, quot);
fi;
else
right_op:= function( v, x )
return ImagesRepresentative( f, PreImagesRepresentative( f, v )^x );
return ImagesRepresentative( f, PreImagesRepresentativeNC( f, v )^x );
end;
qmod:= RightAlgebraModule( RightActingAlgebra( V ),
right_op, quot );
Expand Down
42 changes: 21 additions & 21 deletions lib/autsr.gi
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ local C,M,p,all,gens,sub,q,hom,fp,rels,new,pre,i,free,cnt;
rels:=Filtered(RelatorsOfFpGroup(fp),x->ForAll(ExponentSums(x),x->x mod p=0));
rels:=List(rels,x->ElementOfFpGroup(FamilyObj(One(fp)),x));
new:=RestrictedMapping(nat,C)*hom;
pre:=List(rels,x->PreImagesRepresentative(new,x));
pre:=List(rels,x->PreImagesRepresentativeNC(new,x));
for i in [1..Length(rels)] do
if not pre[i] in sub then
Add(all,MappedWord(rels[i],
Expand All @@ -141,7 +141,7 @@ local ocr,fphom,fpg,free,len,dim,tmp,L0,R,rels,mat,r,RS,i,g,v,cnt;
fpg:=FreeGeneratorsOfFpGroup(Range(fphom));
ocr.factorpres:=[fpg,RelatorsOfFpGroup(Range(fphom))];
ocr.generators:=List(GeneratorsOfGroup(Range(fphom)),
i->PreImagesRepresentative(fphom,i));
i->PreImagesRepresentativeNC(fphom,i));
OCAddMatrices(ocr,ocr.generators);
OCAddRelations(ocr,ocr.generators);
OCAddSumMatrices(ocr,ocr.generators);
Expand Down Expand Up @@ -274,8 +274,8 @@ BindGlobal("AGSRAutomLift",function(ocr,nat,fhom,miso)
# allow to deduce corresponding module aut.
t:=ocr.trickrels;
phom:=IdentityMapping(ocr.moduleauts);
s:=List(t.gens,x->PreImagesRepresentative(nat,x));
l:=List(t.gens,x->PreImagesRepresentative(nat,ImagesRepresentative(fhom,x)));
s:=List(t.gens,x->PreImagesRepresentativeNC(nat,x));
l:=List(t.gens,x->PreImagesRepresentativeNC(nat,ImagesRepresentative(fhom,x)));
s:=List(t.rels,x->MappedWord(x,GeneratorsOfGroup(t.free),s));
l:=List(t.rels,x->MappedWord(x,GeneratorsOfGroup(t.free),l));

Expand All @@ -294,7 +294,7 @@ BindGlobal("AGSRAutomLift",function(ocr,nat,fhom,miso)
Size(Image(phom)));
fi;
for ep in enum do
e:=PreImagesRepresentative(phom,ep);
e:=PreImagesRepresentativeNC(phom,ep);
psim:=e*miso;
psim:=psim^-1;
w:=-List(v,i->i*psim);
Expand Down Expand Up @@ -486,7 +486,7 @@ local S,c,hom,q,a,b,i,t,have,ups,new,u,good,abort,clim,worked,pp,

cnt:=0;
for b in t do
new:=PreImagesRepresentative(hom,b);
new:=PreImagesRepresentativeNC(hom,b);
if (pp=false or new^pp in S) and locond(new) then
S:=ClosureGroup(S,new);
have:=true;
Expand Down Expand Up @@ -1028,7 +1028,7 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
b:=MTX.BasisRadical(mo);
fratsim:=Length(b)=0;
if not fratsim then
b:=List(b,x->PreImagesRepresentative(hom,PcElementByExponents(MPcgs,x)));
b:=List(b,x->PreImagesRepresentativeNC(hom,PcElementByExponents(MPcgs,x)));
for j in b do
N:=ClosureSubgroup(N,b);
od;
Expand Down Expand Up @@ -1129,8 +1129,8 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
if perm in Aperm then
return true;
fi;
aut:=PreImagesRepresentative(AQiso,perm);
newgens:=List(gens,x->PreImagesRepresentative(comiso,
aut:=PreImagesRepresentativeNC(AQiso,perm);
newgens:=List(gens,x->PreImagesRepresentativeNC(comiso,
ImagesRepresentative(aut,ImagesRepresentative(comiso,x))));

mo2:=GModuleByMats(LinearActionLayer(newgens,MPcgs),mo.field);
Expand Down Expand Up @@ -1163,9 +1163,9 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
if perm in Aperm then
return true;
fi;
aut:=PreImagesRepresentative(AQiso,perm);
aut:=PreImagesRepresentativeNC(AQiso,perm);
newgens:=List(GeneratorsOfGroup(Q),
x->PreImagesRepresentative(q,Image(aut,ImagesRepresentative(q,x))));
x->PreImagesRepresentativeNC(q,Image(aut,ImagesRepresentative(q,x))));
mo2:=GModuleByMats(LinearActionLayer(newgens,MPcgs),mo.field);
return MTX.IsomorphismModules(mo,mo2)<>fail;
end;
Expand All @@ -1175,9 +1175,9 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
if perm in Aperm then
return true;
fi;
aut:=PreImagesRepresentative(AQiso,perm);
aut:=PreImagesRepresentativeNC(AQiso,perm);
newgens:=List(GeneratorsOfGroup(Q),
x->PreImagesRepresentative(q,Image(aut,ImagesRepresentative(q,x))));
x->PreImagesRepresentativeNC(q,Image(aut,ImagesRepresentative(q,x))));
mo2:=GModuleByMats(LinearActionLayer(newgens,MPcgs),mo.field);
iso:=MTX.IsomorphismModules(mo,mo2);
if iso=fail then
Expand Down Expand Up @@ -1234,12 +1234,12 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
# stabilize class
k:=SmallGeneratingSet(sub);
ac:=OrbitStabilizerAlgorithm(sub,false,false,
k,List(k,x->PreImagesRepresentative(AQiso,x)),
k,List(k,x->PreImagesRepresentativeNC(AQiso,x)),
rec(pnt:=j,
act:=
function(set,phi)
#local phi;
#phi:=PreImagesRepresentative(AQiso,perm);
#phi:=PreImagesRepresentativeNC(AQiso,perm);
return Set(List(set,x->Image(phi,x)));
end,
onlystab:=true));
Expand Down Expand Up @@ -1367,7 +1367,7 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
GeneratorsOfGroup(rf),
List(GeneratorsOfGroup(rf),
y->ImagesRepresentative(hom,ImagesRepresentative(j,
PreImagesRepresentative(hom,y)))));
PreImagesRepresentativeNC(hom,y)))));
Assert(2,IsBijective(k));
Add(ind,k);
od;
Expand All @@ -1390,7 +1390,7 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
proj:=GroupHomomorphismByImagesNC(AQP,Image(resperm),
B[2],List(GeneratorsOfGroup(res),x->ImagesRepresentative(resperm,x)));
C:=PreImage(proj,Image(resperm,ind));
C:=List(SmallGeneratingSet(C),x->PreImagesRepresentative(AQiso,x));
C:=List(SmallGeneratingSet(C),x->PreImagesRepresentativeNC(AQiso,x));
AQ:=Group(C);
SetIsFinite(AQ,true);
SetIsGroupOfAutomorphismsFiniteGroup(AQ,true);
Expand All @@ -1416,7 +1416,7 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
C:=MappingGeneratorsImages(AQiso);
if C[2]<>GeneratorsOfGroup(AQP) then
C:=[List(GeneratorsOfGroup(AQP),
x->PreImagesRepresentative(AQiso,x)),
x->PreImagesRepresentativeNC(AQiso,x)),
GeneratorsOfGroup(AQP)];
fi;
for j in u do
Expand Down Expand Up @@ -1450,7 +1450,7 @@ local ff,r,d,ser,u,v,i,j,k,p,bd,e,gens,lhom,M,N,hom,Q,Mim,q,ocr,split,MPcgs,
substb:=SmallGeneratingSet(substb);
AQP:=Group(substb);
SetSize(AQP,B);
C:=[List(substb,x->PreImagesRepresentative(AQiso,x)),substb];
C:=[List(substb,x->PreImagesRepresentativeNC(AQiso,x)),substb];
fi;

od;
Expand Down Expand Up @@ -1883,7 +1883,7 @@ local d,a,map,cG,nG,nH,i,j,u,v,asAutomorphism,K,L,conj,e1,e2,
else
gens:=SmallGeneratingSet(api);
fi;
pre:=List(gens,x->PreImagesRepresentative(iso,x));
pre:=List(gens,x->PreImagesRepresentativeNC(iso,x));
map:=RepresentativeAction(SubgroupNC(a,pre),u,v,asAutomorphism);
if map=fail then
return fail;
Expand All @@ -1904,6 +1904,6 @@ local d,a,map,cG,nG,nH,i,j,u,v,asAutomorphism,K,L,conj,e1,e2,
fi;

return GroupHomomorphismByImagesNC(G,H,GeneratorsOfGroup(G),
List(GeneratorsOfGroup(G),x->PreImagesRepresentative(e2,
List(GeneratorsOfGroup(G),x->PreImagesRepresentativeNC(e2,
Image(conj,Image(e1,x)))));
end);
2 changes: 1 addition & 1 deletion lib/clas.gi
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ local H,cl,a,c;
H:=Image(hom,G);
cl:=[];
for c in ConjugacyClasses(H) do
a:=ConjugacyClass(G,PreImagesRepresentative(hom,Representative(c)));
a:=ConjugacyClass(G,PreImagesRepresentativeNC(hom,Representative(c)));
if HasStabilizerOfExternalSet(c) then
SetStabilizerOfExternalSet(a,PreImage(hom,StabilizerOfExternalSet(c)));
fi;
Expand Down
Loading
Loading