Skip to content

[Cleanup] MethodType in baselines files replaced in favor of class forward functions in methods - #395

Open
sami-bg wants to merge 3 commits into
galilai-group:mainfrom
sami-bg:feature/method-types
Open

[Cleanup] MethodType in baselines files replaced in favor of class forward functions in methods#395
sami-bg wants to merge 3 commits into
galilai-group:mainfrom
sami-bg:feature/method-types

Conversation

@sami-bg

@sami-bg sami-bg commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Description

Addresses PR comment in #394

Checklist

  • I have read the Contributing document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR to the RELEASES.rst file.

@RandallBalestriero

Copy link
Copy Markdown
Contributor

Hi @sami-bg ! Thanks for the PR, quick question, what is the motivation for the naming of forward_model and use of this method instead of the usual forward?

@sami-bg

sami-bg commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

Hello hello! I was sticking with the convention of having the forward function be reserved for one that operates directly from the batch dict (eg sticking to (self, batch, stage) arg signature), although now that you mention it, it would be useful to merge forward_model into forward since forward_model is what computes the loss. Will address that soon!

@sami-bg

sami-bg commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants