fix: allow escaped backslash (\\) in regex bodies - #50
Merged
gajus merged 3 commits intoJun 11, 2026
Merged
Conversation
![libra-exla[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…regressions The "escaped line terminators" test (path:/foo\<newline>bar/) parses on the pre-fix grammar via the existing `"\\" [^\\]` rule, so it guards nothing. Replace it with two tests that exercise the new `"\\" "\\"` rule and fail without the fix: a trailing escaped backslash (path:/^C:\\test\\/) and a triple-backslash sequence (foo:/a\\\b/).
…-escaped-backslash
|
🎉 This PR is included in version 3.8.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49
Problem
A liqe regex body cannot contain an escaped backslash (
\\), so patterns likefield:/^C:\\test.*/(Windows paths) fail to parse. The grammar'sregex_body_charonly allowed\followed by a non-backslash character.Fix
Add a grammar rule that accepts
\\and emits two literal backslashes. The generated parser (src/grammar.ts) is regenerated vianpm run compile-parserand is byte-identical to the committed change, so there is no source/generated drift.Tests
Added a regression test (
path:/^C:\\test.*/) that throws before the fix and parses after. The full AVA suite passes.