Consistently emit close event after quit even if server rejects - #189
Merged
Merged
Conversation
SimonFrings
requested changes
Nov 28, 2023
SimonFrings
left a comment
SimonFrings
left a comment
Contributor
There was a problem hiding this comment.
PR looks good, only found a small oversight inside the documentation for the quit() function
Contributor
Author
|
Rebased to fix merge conflict now that #188 is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset ensures we consistently emit a
closeevent after aquit()call even if the server rejects. This is more of an edge case I've encountered while working on support for multiple connections as discussed in #175, so I figured it makes sense to properly close the connection in case the server does not already do this as usually expected.Follow-up PRs will build on top of this to use dedicated
openandcloseevents as discussed in #147 and support multiple connections as discussed in #175.Builds on top of #187