Skip to content

fix: validate the target user in save_role - #3376

Open
rs-rethik wants to merge 1 commit into
frappe:developfrom
aerele:fix/save-role-target-user
Open

rs-rethik wants to merge 1 commit into
frappe:developfrom
aerele:fix/save-role-target-user

Conversation

@rs-rethik

@rs-rethik rs-rethik commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Issue:

save_role did not check the target user. A user with the Moderator role could:

  • Give any LMS role to Guest. A Moderator role on Guest applies to every visitor who is not logged in.
  • Change the roles of Administrator.
  • Change the roles of a System Manager.
  • Write a Has Role row for a user that does not exist.

update_member and delete_member already block these cases. save_role did not.

@rs-rethik
rs-rethik marked this pull request as ready for review November 20, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant