Skip to content

feat(setup): show Learning taking shape beside the setup steps - #3370

Draft
pateljannat wants to merge 7 commits into
frappe:developfrom
pateljannat:feat/setup-preview
Draft

pateljannat wants to merge 7 commits into
frappe:developfrom
pateljannat:feat/setup-preview

Conversation

@pateljannat

@pateljannat pateljannat commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Needs frappe/frappe#47963 merged first.

Setup shows Learning taking shape beside the questions

The setup page showed one fixed picture of the home page. Nothing on it changed as the admin answered, so the questions felt disconnected from the app.

The page now shows Learning itself next to the steps, built from its own sidebar, list pages and cards. Each answer changes it: the use case picks the sample courses, the tool opens the import menu, the goal moves to courses or batches, and invited people show up on the cards. When setup ends, the preview swaps to the site's own courses or batches and grows into that page. The question also stays at one height on every step.

Before After


A sample batch in the demo data

The demo data had a course but no batch, so an admin who picked "Onboard my existing learners" landed on an empty Batches page.

The demo data now adds a batch, "Course Builders Cohort", with the demo learners in it. Telemetry does not count it, and clearing the demo data removes it.


Moderators can be batch instructors

The instructor picker on the batch form and the new batch dialog listed only Course Creators and Batch Evaluators. A moderator with no other role could not teach a batch.

Both pickers now list moderators too.


Invite people from Settings

After setup, Learning had no way to invite anyone, and people already invited did not show anywhere until they accepted.

Settings now has an Invites page under User Management, next to Users, laid out like the invite pages in Helpdesk and CRM. Moderators enter emails, pick a role and send the invites. Pending invites are listed below, and each one can be cancelled.

Before After

Smaller changes

Batch Evaluator can be invited from setup. The Getting started panel fades in instead of popping up when the admin lands from setup. The "Read the docs" button in empty states is secondary. One line in get_country_code is formatted, so Linters passes on develop again.

The instructor picker on the batch form and the new batch dialog searched only Course Creators and Batch Evaluators, so a moderator with no other role could not teach a batch.
The setup page shows the app next to the questions, built from its own
sidebar, list pages and cards with sample data for the chosen use case. Each
answer changes the preview, and on finish it grows into the page the goal
opens.

The demo data adds a sample batch that telemetry does not count. Batch
Evaluator can be invited from setup. The Getting started panel fades in,
and the docs button in empty states is secondary.
@pateljannat

Copy link
Copy Markdown
Member Author

@frappe-guard review

Invites sent from setup had nowhere to show until the person accepted. Settings now has an Invites page beside Users that lists them, with search, and lets an admin resend or cancel each one.
@pateljannat

Copy link
Copy Markdown
Member Author

@frappe-guard review again

The Invites page only listed pending invites, so after setup there was no way to invite anyone. It now has the invite form Helpdesk and CRM use: emails, a role with what it allows, and Send invites, with the pending invites below.
@pateljannat

Copy link
Copy Markdown
Member Author

@frappe-guard review again

@pateljannat

Copy link
Copy Markdown
Member Author

@frappe-guard review again

@pateljannat
pateljannat marked this pull request as draft November 19, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant