Repository navigation
feat(setup): show Learning taking shape beside the setup steps - #3370
Draft
pateljannat wants to merge 7 commits into
Draft
pateljannat wants to merge 7 commits into
pateljannat wants to merge 7 commits into
Conversation
The instructor picker on the batch form and the new batch dialog searched only Course Creators and Batch Evaluators, so a moderator with no other role could not teach a batch.
The setup page shows the app next to the questions, built from its own sidebar, list pages and cards with sample data for the chosen use case. Each answer changes the preview, and on finish it grows into the page the goal opens. The demo data adds a sample batch that telemetry does not count. Batch Evaluator can be invited from setup. The Getting started panel fades in, and the docs button in empty states is secondary.
Member
Author
|
@frappe-guard review |
Invites sent from setup had nowhere to show until the person accepted. Settings now has an Invites page beside Users that lists them, with search, and lets an admin resend or cancel each one.
Member
Author
|
@frappe-guard review again |
The Invites page only listed pending invites, so after setup there was no way to invite anyone. It now has the invite form Helpdesk and CRM use: emails, a role with what it allows, and Send invites, with the pending invites below.
Member
Author
|
@frappe-guard review again |
Member
Author
|
@frappe-guard review again |
pateljannat
marked this pull request as draft
November 19, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs frappe/frappe#47963 merged first.
Setup shows Learning taking shape beside the questions
The setup page showed one fixed picture of the home page. Nothing on it changed as the admin answered, so the questions felt disconnected from the app.
The page now shows Learning itself next to the steps, built from its own sidebar, list pages and cards. Each answer changes it: the use case picks the sample courses, the tool opens the import menu, the goal moves to courses or batches, and invited people show up on the cards. When setup ends, the preview swaps to the site's own courses or batches and grows into that page. The question also stays at one height on every step.
A sample batch in the demo data
The demo data had a course but no batch, so an admin who picked "Onboard my existing learners" landed on an empty Batches page.
The demo data now adds a batch, "Course Builders Cohort", with the demo learners in it. Telemetry does not count it, and clearing the demo data removes it.
Moderators can be batch instructors
The instructor picker on the batch form and the new batch dialog listed only Course Creators and Batch Evaluators. A moderator with no other role could not teach a batch.
Both pickers now list moderators too.
Invite people from Settings
After setup, Learning had no way to invite anyone, and people already invited did not show anywhere until they accepted.
Settings now has an Invites page under User Management, next to Users, laid out like the invite pages in Helpdesk and CRM. Moderators enter emails, pick a role and send the invites. Pending invites are listed below, and each one can be cancelled.
Smaller changes
Batch Evaluator can be invited from setup. The Getting started panel fades in instead of popping up when the admin lands from setup. The "Read the docs" button in empty states is secondary. One line in
get_country_codeis formatted, so Linters passes on develop again.