Repository navigation
fix(rtl): flip arrows, tabs, menus, and layout for right-to-left languages - #3295
Merged
raizasafeel merged 6 commits intoNov 16, 2026
Merged
Conversation
Semgrep's tailwind-rtl gate only sees physical utility classes. This covers what it can't: prev/next and back chevrons, icons passed to frappe-ui as names (moved to slots), always-directional lucide icons mirrored in index.css, centred overlays built from start-1/2 -translate-x-1/2, the inline lesson menu and notification panel positioning, the audio played fill, and tooltip/dropdown sides through inlineStartSide/inlineEndSide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Wrap the app in reka-ui's ConfigProvider with the document direction. Reka stamped dir="ltr" on TabButtons, the Settings dialog tabs and the sidebar scroll area, so tabs read left to right, the Settings dialog laid out LTR and the sidebar rows kept their icons on the left. - Port CRM's index.css patches for frappe-ui parts that hardcode a side: the TextEditor placeholder, the sidebar item padding and label gap (which also offset the collapsed sidebar's bottom icons), and toasts, which now sit bottom-left instead of over the sidebar. - Mirror frappe-ui Progress so it fills from the right, flip the ListSelectBanner divider, and keep keyboard shortcuts left to right. - Force the CodeMirror editors LTR; isolate the YouTube URL input and the thumbnail dimensions so they no longer show only their tail or wrap around the ×. Batch time ranges take dir="auto": forced LTR, the localized "10:00 ص - 11:30 ص" came out scrambled. - Give the batch dashboard chart's axis labels room for Arabic descenders, which echarts clipped into stray commas. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frappe-ui's Select, Combobox and MultiSelect triggers use a physical text-left for the value and ml-auto for Select's chevron, so in RTL the value sat at the far end and the chevron right beside it (Instructors, Medium and every other picker with a value). Patch both from index.css next to the other frappe-ui RTL fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
raizasafeel
added a commit
to raizasafeel/lms
that referenced
this pull request
Nov 16, 2026
frappe-ui's SettingsNavItem stretches the label with a physical left alignment, so in RTL each label sat at the far edge, away from its icon, and SettingsSidebar drew its divider on the outer side. Settings.vue tags the sidebar so index.css can align the label to the start and move the divider, alongside the other frappe-ui RTL patches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@greptile review |
Contributor
[Medium impact] RTL layout changes reach shared LMS controls across student and admin pages. Appears safe to merge, with one small RTL icon correction. Reviews (1) · Last reviewed commit: "Merge branch 'develop' into fix/rtl-dire..." · Reviewed by Greptile |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes LMS read and point correctly for Arabic, Hebrew, Persian, and Urdu users, and for sites with the "Right to Left" text direction setting.
Why
What changed
ConfigProviderwith the page direction, and EditorJS lesson blocks get the same wrapper. Before this, tabs on Courses, Batches, Programs, Jobs, and Profile, the Settings dialog, and sidebar rows opened left to right.reka-uiis now a declared dependency, using the same version range frappe-ui uses. No lockfile change.index.cssuntil frappe-ui fixes them:Screenshots
Arabic UI with right-to-left on. Each pair is cropped to the part of the page that changed. Before:
develop. After: this PR. Both use develop's existing Arabic translations, so only layout and direction differ.Sidebar (1)
Admin pages (6)
Assignments (6)
Batch learning (2)
Batches (6)
Course admin (4)
Courses (2)
Jobs (4)
Learning (2)
Profile (2)
Programming Exercises (6)
Programs (2)
Taking a quiz (1)
Quizzes (3)
Testing
setupPage.test.ts. They fail the same way ondevelopon our bench, because the bench's frappe predates SetupFlow. Not caused by this PR.develop.🤖 Generated with Claude Code