Skip to content

fix: allow updating an existing course review - #2923

Open
rs-rethik wants to merge 1 commit into
frappe:developfrom
aerele:fix/course-review-update
Open

rs-rethik wants to merge 1 commit into
frappe:developfrom
aerele:fix/course-review-update

Conversation

@rs-rethik

@rs-rethik rs-rethik commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Issue:
A course review could not be edited after it was created. Saving any change to an existing LMS Course Review threw "You have already reviewed this course".

validate_if_already_reviewed checked whether any review existed for the same course and owner, without excluding the document being saved. On update, the check matched the document's own row and aborted.

@rs-rethik
rs-rethik marked this pull request as ready for review October 12, 2026 10:33
@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Reviews (3) · Last reviewed commit: "fix: allow updating an existing course r..." · Reviewed by Greptile

@rs-rethik
rs-rethik force-pushed the fix/course-review-update branch 2 times, most recently from 001e210 to a900635 Compare October 12, 2026 11:08
@github-actions

Copy link
Copy Markdown

Hi @rs-rethik, thanks for your interest in contributing!

This project requires that pull request authors are vouched, and you are not in the list of vouched users.

This PR will be closed automatically. See https://github.com/frappe/lms/blob/develop/CONTRIBUTING.md for more details.

@github-actions github-actions Bot closed this Oct 12, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (620a87c) to head (a900635).
⚠️ Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
...lms/doctype/lms_course_review/lms_course_review.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2923      +/-   ##
===========================================
+ Coverage    88.09%   88.51%   +0.42%     
===========================================
  Files          251      252       +1     
  Lines        21703    22100     +397     
===========================================
+ Hits         19119    19562     +443     
+ Misses        2584     2538      -46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rs-rethik

Copy link
Copy Markdown
Contributor Author

@raizasafeel review and reopen this too

@raizasafeel raizasafeel reopened this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants