-
Notifications
You must be signed in to change notification settings - Fork 221
docs: propose backward-compatible typed per-message fields #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amacneil
wants to merge
6
commits into
main
Choose a base branch
from
cursor/spec-n-timestamps-bb7e
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
863354e
docs: propose backward-compatible N auxiliary timestamps per message
cursoragent c32cee6
ci: add 'seekable' to cspell dictionary
cursoragent e90cded
docs: rework proposal into unified typed message fields
cursoragent 7314361
docs: add field sentinel to signal and detect dropped fields records
cursoragent 107db43
docs: add float16 to field encodings registry
cursoragent de4a98a
docs: make field indexing implicit, drop indexed flag
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,6 +111,7 @@ words: | |
| - rustup | ||
| - Saronic | ||
| - schemaless | ||
| - seekable | ||
| - serde | ||
| - sfixed | ||
| - srgb | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min_value/max_valueare typeduint64, but indexed encodings now includeint64andfloat64— two things bake in here:Ordering. Pruning compares the query against
[min_value, max_value]. Treating these as rawuint64(as the type column says) gives wrong results forint64(negative two's-complement sorts above positives) andfloat64(sign bit + bit-pattern order ≠ numeric order). The Field Indexrecordsvalue column and the Statisticsfield_value_boundsshare the trap. Either state explicitly that min/max and all comparisons use the field's logical type ordering — and define whatfloat64NaN /±0do — or restrict indexing touint64/timestamp.Zero sentinel. "Zero if no messages in the chunk carry it" collides with a legitimate value of
0(common for int/float, unlikelog_time). A chunk with no field-carrying messages is then indistinguishable from one whose values are all0, so avalue == 0query can't prune it. If a Field Chunk Index is emitted per (chunk, indexed field) regardless of presence, add an explicit presence/count signal rather than overloading0.