Skip to content

cpp: BufferWriter: Reserve chunkSize in constructor #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clalancette merged 1 commit into from
Jun 4, 2026
+7 −1
Merged

cpp: BufferWriter: Reserve chunkSize in constructor #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cpp/mcap/include/mcap/writer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,8 @@ class MCAP_PUBLIC IChunkWriter : public IWritable {
*/
class MCAP_PUBLIC BufferWriter final : public IChunkWriter {
public:
explicit BufferWriter(uint64_t chunkSize = 0);

void handleWrite(const std::byte* data, uint64_t size) override;
void end() override;
uint64_t size() const override;
Expand Down
6 changes: 5 additions & 1 deletion cpp/mcap/include/mcap/writer.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ void IChunkWriter::clear() {

// BufferWriter //////////////////////////////////////////////////////////////

BufferWriter::BufferWriter(uint64_t chunkSize) {
buffer_.reserve(chunkSize);
}

void BufferWriter::handleWrite(const std::byte* data, uint64_t size) {
buffer_.insert(buffer_.end(), data, data + size);
}
Expand Down Expand Up @@ -313,7 +317,7 @@ void McapWriter::open(IWritable& writer, const McapWriterOptions& options) {
switch (compression_) {
case Compression::None:
default:
uncompressedChunk_ = std::make_unique<BufferWriter>();
uncompressedChunk_ = std::make_unique<BufferWriter>(chunkSize_);
break;
#ifndef MCAP_COMPRESSION_NO_LZ4
case Compression::Lz4:
Expand Down
Loading