fix: remove include prop from nyc config

[mdonnalley]

@W-11670631@

[cristiand391]

Tested using plugin-alias, removed include prop from node_modules/@salesforce/dev-config/nyc.json and increased code cov to 100%, nyc still pass even though coverage is below 100%.

The only change needed is to remove the nyc prop from the .nycrc file in each repo, which dev-scripts does if you delete the .nycrc file and run yarn install, template: https://github.com/forcedotcom/dev-scripts/blob/main/files/nycrc

re: overriding settings
there's an open PR to fix this in nyc: istanbuljs/load-nyc-config#19

[mdonnalley]

Tested using plugin-alias, removed include prop from node_modules/@salesforce/dev-config/nyc.json and increased code cov to 100%, nyc still pass even though coverage is below 100%.

The only change needed is to remove the nyc prop from the .nycrc file in each repo, which dev-scripts does if you delete the .nycrc file and run yarn install, template: https://github.com/forcedotcom/dev-scripts/blob/main/files/nycrc

re: overriding settings there's an open PR to fix this in nyc: istanbuljs/load-nyc-config#19

@cristiand391 interesting. It seems that our nyc-config works for some plugins (like plugin-alias) but not for others (like ones generated using plugin-dev)...

Guess I'll go back to the drawing board