Skip to content

Fix wikilinks on folder to markdown link #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Morikko wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix wikilinks on folder to markdown link #1744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/foam-vscode/src/vscode/features/editing/convert-links.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,28 @@ describe('Link Conversion Commands', () => {
await deleteFile(uri);
});

it('should convert a directory wikilink to its resolved index file', async () => {
const readme = await createFile('# My Folder Index', [
'my-folder',
'README.md',
]);
const { uri } = await createFile('Text before [[my-folder]] text after');
const { editor } = await showInEditor(uri);
await waitForNoteInFoamWorkspace(readme.uri);

editor.selection = new vscode.Selection(0, 15, 0, 15);

await vscode.commands.executeCommand(CONVERT_WIKILINK_TO_MDLINK.command);

const result = editor.document.getText();
expect(result).toBe(
'Text before [My Folder Index](my-folder/README.md) text after'
);

await deleteFile(readme.uri);
await deleteFile(uri);
});

it('should show info message when no wikilink at cursor', async () => {
const { uri } = await createFile('Text with no wikilinks');
const { editor } = await showInEditor(uri);
Expand Down
5 changes: 4 additions & 1 deletion packages/foam-vscode/src/vscode/features/editing/convert-links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ async function convertWikilinkToMarkdown(foam: Foam): Promise<void> {
}

const linkInfo = MarkdownLink.analyzeLink(targetLink);
const targetResource = foam.workspace.find(linkInfo.target);
// Resolve the link the way navigation does. resolveLink may embed the
// section as a URI fragment; strip it to get the resource URI.
const targetUri = foam.workspace.resolveLink(resource, targetLink).asPlain();
const targetResource = foam.workspace.find(targetUri);
if (!targetResource) {
throw new Error(`Resource "${linkInfo.target}" not found`);
}
Expand Down