Pencil datareducer - #1346
Open
veetihaaja wants to merge 3 commits into
Open
Pencil datareducer#1346veetihaaja wants to merge 3 commits into
veetihaaja wants to merge 3 commits into
Conversation
NOTE: these IDs are rank-specific
ykempf
reviewed
Sep 7, 2026
| getSeedIdsTimer.stop(); | ||
|
|
||
|
|
||
| for (auto c : localCells){ |
Contributor
There was a problem hiding this comment.
Not a very optimal loop – and is this running only when an IO is upcoming?
…the data gathering if the DRO is active. Takes a neglibilible amount of computation time since its only called at init / LB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title, added data into CellParams and further into a datareducer to show
Note: the pencil IDs are local, so in an MPI simulation, the id can change at process boundaries