Better rng - #1290
Open
lassejsc wants to merge 6 commits into
Open
Better rng#1290lassejsc wants to merge 6 commits into
lassejsc wants to merge 6 commits into
Conversation
…multiplier for less correlated seeds
lassejsc
marked this pull request as ready for review
June 1, 2026 14:52
P::tstep is uint, we want to maybe convert it to uint64 before doing the calculation(?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier the vlasovmover used the default_random_engine which was quite bad at not being correlated for subsequent timesteps if we generate couple numbers. This has been now exchanged to use
std::knuth_b, and to make it truly bit more random there is no a scalar multiplier added to theP::timestepseeding which can be adjusted viamap_order.seedparameter.