Conversation
…mented pencil threading with tc
…. currently if function increases currentmaximumtimeclass, something breaks.
…, so certain cells can be accelerated when they need to be rolled back. Compiles and runs, but causes rhom-diffs etc.
…tionality not yet implemented
…. Dropping timeclasses seems to work, as long as highest timeclass isnt raised. physical diffs seem small
…s, and dynamic timeclass allocation is done without the buffer. This is to allow maxTimeclass and currentmaxtimeclass to be higher than the tc of the fs-cadence timeclass.
…ir timeclass turn
…at fractimestep0 for high timeclasses
…erformance for a long time. Rule of five additions; not sure if const copy constructors are actually good here
…erformance for a long time. Rule of five additions; not sure if const copy constructors are actually good here
…t in the same cell.
…hborhoods may be large enough to reach there.
…llhaloextent to parameters
…Grid neighborhood_size
…lass for active translation cells
…timeclass activity - no need to re-check after using neighbor search functions.
…is used for no-timeclass marker as well. Need a better flag.
…eighbor searches after all, in some cases. Optimally this would not be speculative, but thems them apples at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should merge as-is so it should actually run current CI.
Let's see how much it dies.