-
-
Notifications
You must be signed in to change notification settings - Fork 602
refactor: moved wait and analysis stores to pinia #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from 1 commit
ac1f4f8
a8ffde2
300d450
9106c11
0c608c5
86911e1
bcd51c8
fde7480
ea7fb1c
fb31ac6
c48da94
b849d4b
2c3d5c4
72a6c9a
43ec38b
3aeab67
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ import { Waits } from '@/globals' | |
| import type { FileFilterType } from '../files/types' | ||
| import { TinyColor } from '@ctrl/tinycolor' | ||
| import dbKey from '@/util/db-key' | ||
| import { useWaitStore } from '../../stores/wait' | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. low. Relative Given
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, that's my error, ill standardize to '@/' I see valid concern here about store/stores. I took the naming from Pinia's migration guide regarding stores. End state @/stores makes a more descriptive folder structure for maintainability long term and fits the style of the rest of the code base where folders are generally descriptive by function rather than library. How would you like to proceed?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you, please continue with |
||
| export const actions = { | ||
| /** | ||
|
|
@@ -58,7 +59,7 @@ export const actions = { | |
| // vuetify.framework.lang.current = state.uiSettings.general.locale | ||
|
|
||
| // Add the wait. | ||
| dispatch('wait/addWait', Waits.onLoadLanguage, { root: true }) | ||
| useWaitStore().addWait(Waits.onLoadLanguage) | ||
|
|
||
| // Grab the browsers starting locale. | ||
| const startingLocale = getStartingLocale() | ||
|
|
@@ -78,7 +79,7 @@ export const actions = { | |
| server: true | ||
| }) | ||
| } | ||
| dispatch('wait/removeWait', Waits.onLoadLanguage, { root: true }) | ||
| useWaitStore().removeWait(Waits.onLoadLanguage) | ||
| }, | ||
|
|
||
| /** | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.