Repository navigation
fix(authz): close list-endpoint scope bypass - #6662
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #6662 +/- ##
==========================================
+ Coverage 70.69% 70.74% +0.04%
==========================================
Files 152 152
Lines 14218 14234 +16
==========================================
+ Hits 10052 10070 +18
+ Misses 4166 4164 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: approve
The fix correctly closes the authorization bypass: undefined viewable_environments and viewable_namespaces scopes now require an explicit allowed decision before defaulting to unrestricted (["*"]), and ListNamespaces additionally verifies the requested environment is viewable. The logic is sound, tests cover edge cases well (including nil environment, query failures, and hidden-environment denials), and error handling follows existing patterns. No issues found.
🤖 Automated review by the Flipt PR review agent.
ListNamespaces now denies environments hidden by viewable_environments. Undefined list scopes fall back to the allow decision instead of an unrestricted list. Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
57591ad to
d9be13f
Compare
2 participants
ListNamespaces now denies environments hidden by viewable_environments.
Undefined list scopes fall back to the allow decision instead of an unrestricted list.