Skip to content

Fix cubic complexity of nmod_mat_equal #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edgarcosta merged 1 commit into from
Aug 24, 2026
Merged

Fix cubic complexity of nmod_mat_equal #2811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/nmod_mat/equal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
int
nmod_mat_equal(const nmod_mat_t mat1, const nmod_mat_t mat2)
{
slong i, j;
slong i;

if (mat1->r != mat2->r || mat1->c != mat2->c)
return 0;
Expand All @@ -25,11 +25,8 @@ nmod_mat_equal(const nmod_mat_t mat1, const nmod_mat_t mat2)

for (i = 0; i < mat1->r; i++)
{
for (j = 0; j < mat1->c; j++)
{
if (!_nmod_vec_equal(nmod_mat_entry_ptr(mat1, i, 0), nmod_mat_entry_ptr(mat2, i, 0), mat1->c))
return 0;
}
if (!_nmod_vec_equal(nmod_mat_entry_ptr(mat1, i, 0), nmod_mat_entry_ptr(mat2, i, 0), mat1->c))
return 0;
}

return 1;
Expand Down
Loading