Bugfix: Patch QPay service callback URL, and ensure callbackUrl is pr… - #90
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1742 1742
===========================================
Files 135 135
Lines 7699 7699
===========================================
Hits 7699 7699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
Apply review findings from the callback URL fix: - Single-source the capture callback URL in QPay::callbackUrl(), honoring the configurable storefront route prefix instead of hardcoding it in two files, and document the constructor default as a last resort that cannot carry a checkout id. - Set the per-checkout callback once via setCallback() instead of threading it through optional trailing invoice arguments, so every invoice path on the instance uses it and future call sites cannot silently omit it. - Drop the duplicated callback fallback blocks in createSimpleInvoice and createEbarimtInvoice; createQPayInvoice already applies the identical fallback for both. - Remove a stray leading quote from the paymentCancel/paymentRefund callback_url literals. - Cache the QPay access token across requests (keyed by base URI and username, until shortly before expiry) instead of re-authenticating on every checkout and callback. - Batch-fetch cart products once for invoice line building and let the classification/tax-code helpers accept a preloaded product, removing up to two duplicate product queries per cart item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.