routine to generate balanced initial fields for SWE - #759
Open
jshipton wants to merge 2 commits into
Open
Conversation
… and zero time-change to divergence, given vorticity
tommbendall
requested changes
Sep 8, 2026
| def nondivergent_flow(equation, zeta0, u0, D0): | ||
| """ | ||
| Returns u0 and D0, balanced velocity and depth fields, given a | ||
| vorticity field zeta0. Balance is defined as |
Contributor
There was a problem hiding this comment.
There's a missing comment here!
| _, D = w.subfunctions | ||
| D0.assign(D) | ||
|
|
||
| # adjust depth to have initial mean of H as set in the parameters |
Contributor
There was a problem hiding this comment.
Are there any situations where we might want to set this differently? e.g. the min/max, or specifying some mean that isn't H? If so we could specify that through the argument list
|
|
||
| Args: | ||
| equation (:class:`PrognosticEquation`): the model's equation object. | ||
| zeta0 (:class:`ufl.Expr`): the input vorticity field. |
Contributor
There was a problem hiding this comment.
Is it always the relative vorticity? Could that be mentioned in the comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine to initialise shallow water flows from a given vorticity field such that the initial flow is non divergent and has div(u_t)=0. The steps are: