This repository was archived by the owner on Apr 16, 2026. It is now read-only.
gossip: add GossipDecodeHarness for v2 conformance testing - #222
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Solana “gossip” protobuf surface and introduces a new GossipDecodeHarness intended for v2 conformance testing using the sol_compat_gossip_decode_v1 entrypoint, including support for fixtures whose input is a scalar bytes field.
Changes:
- Regenerates/updates gossip protobuf stubs to include new
GossipFixture/GossipEffectsmessage types. - Adds
GossipDecodeHarnessand anencode_effectshook for human-readable output handling. - Removes obsolete generated protobuf modules (
pack_pb2.py,shred_pb2.py) and drops the Pack harness wiring.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test_suite/protos/shred_pb2.py | Removes generated shred protobuf stub. |
| src/test_suite/protos/pack_pb2.py | Removes generated pack protobuf stub. |
| src/test_suite/protos/gossip_pb2.py | Updates generated gossip protobuf stub to include decode fixture/effects messages. |
| src/test_suite/gossip/codec_utils.py | Adds encode_effects no-op for new GossipEffects output type. |
| src/test_suite/fuzz_interface.py | Changes harness initialization to allow scalar (non-message) fixture inputs. |
| src/test_suite/fuzz_context.py | Removes Pack harness and registers new GossipDecodeHarness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mjain-jump
approved these changes
Apr 10, 2026
Update protosol submodule to v5.4.0, regenerate gossip protobuf stubs, and add GossipDecodeHarness using sol_compat_gossip_decode_v1 entry point. Handles scalar bytes input (GossipFixture.input) and guards removed pack_pb2 import.
cmoyes-jump
force-pushed
the
cmoyes/gossip-decode
branch
from
April 10, 2026 22:30
da693eb to
a98aca3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update protosol submodule to v5.4.0, regenerate gossip protobuf stubs, and add GossipDecodeHarness using sol_compat_gossip_decode_v1 entry point. Handles scalar bytes input (GossipFixture.input) and guards removed pack_pb2 import.