This repository was archived by the owner on Apr 16, 2026. It is now read-only.
plumb enable vm tracing - #145
Merged
Merged
Conversation
cali-jumptrading
force-pushed
the
cali/plumb-enable-vm-tracing
branch
6 times, most recently
from
August 29, 2025 17:40
2055281 to
a54ff1b
Compare
mjain-jump
self-requested a review
August 29, 2025 17:46
mjain-jump
reviewed
Aug 29, 2025
| shutil.rmtree(globals.output_dir) | ||
| globals.output_dir.mkdir(parents=True, exist_ok=True) | ||
|
|
||
| os.environ.pop("ENABLE_VM_TRACING", None) |
Collaborator
There was a problem hiding this comment.
why do we need this here?
Contributor
Author
There was a problem hiding this comment.
cuz it's an environment variable so we need to make sure it's fully cleared when we don't want to enable vm tracing
mjain-jump
reviewed
Aug 29, 2025
cali-jumptrading
force-pushed
the
cali/plumb-enable-vm-tracing
branch
from
August 29, 2025 18:15
a54ff1b to
fc36a53
Compare
mjain-jump
reviewed
Aug 29, 2025
Comment on lines
+415
to
+419
| enable_vm_tracing: bool = typer.Option( | ||
| False, | ||
| "--enable-vm-tracing", | ||
| "-evm", | ||
| help="Enable FD VM tracing", | ||
| ), |
Collaborator
There was a problem hiding this comment.
vm tracing probably isnt needed for run_tests, stdout is not captured properly anyways because tests may be run in parallel so the output wont be legible
Contributor
Author
There was a problem hiding this comment.
I added the option to run-tests because I sometimes use run-tests to run both agave and firedancer for a single target.
Collaborator
There was a problem hiding this comment.
when tracing is added to agave its going to print garbage into stdout
mjain-jump
reviewed
Aug 29, 2025
cali-jumptrading
force-pushed
the
cali/plumb-enable-vm-tracing
branch
from
August 29, 2025 18:24
fc36a53 to
8375d9e
Compare
cali-jumptrading
force-pushed
the
cali/plumb-enable-vm-tracing
branch
from
August 29, 2025 18:28
8375d9e to
f4079b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.