shred: clean up discard_unexpected_data_complete_shreds - #131
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes a previously defined shred feature flag from the protobuf API while preserving the field tag via reserved, and bumps the crate version accordingly.
Changes:
- Removes
discard_unexpected_data_complete_shredsfromShredFeaturesand reserves tag1. - Regenerates Rust protobuf bindings so
ShredFeaturesbecomes an empty message type. - Bumps crate version from
12.0.0to13.0.0.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/generated/org.solana.sealevel.v1.rs | Updates generated Rust types to reflect that ShredFeatures no longer contains fields. |
| proto/shred.proto | Removes the boolean field and reserves protobuf tag 1 to prevent reuse. |
| Cargo.toml | Increments crate version to reflect the breaking API change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mjain-jump
force-pushed
the
mjain/remove-old-shred-feature
branch
from
August 17, 2026 22:02
193c716 to
b1c238d
Compare
mjain-jump
force-pushed
the
mjain/remove-old-shred-feature
branch
from
August 17, 2026 22:03
b1c238d to
e72cbbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.