Expose slide boundary anchors for presentations - #95
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 13 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
|
Independent verification. We're evaluating anydoc as the extraction layer for a documentation-ingestion pipeline that consumes the document model rather than the Markdown serializer, so slide boundaries are load-bearing for us. We tested this PR and #32 against the same deck; notes on both, and the clippy question answered. Setup: merge-base
On the clippy failure you flagged — your claim checks out, and it is not yours. Three Document model on that deck. Baseline v0.1.9 gives 4 top-level blocks with no marker of any kind — The untitled slide separates correctly, and the marker carries the ordinal. Why we'd prefer this over #32, having run both. #32 works — it emits
It's also the smaller change than the diffstat suggests — v0.1.9 already builds One gap, in fairness to #32: this PR doesn't touch the ODF frontend. On The two PRs conflict — #32 applies cleanly to Happy to re-run any of this on other fixtures if it's useful. |
Summary
slide-Nanchors for every PPTX slide instead of only slides targeted by internal linksslide-Nanchors for legacy PPT slides in presentation orderTests
cargo fmt --checkcargo test slide_anchorcargo testgit diff --checkNot passing locally:
cargo clippy --all-targets -- -D warningsfails on existing unrelatedclippy::collapsible_matchwarnings insrc/formats/rtf/tables.rs.Refs #94
Summary by cubic
Expose slide boundary anchors for every PPTX and PPT slide and render them only for presentations. Previously PPTX anchors appeared only on slides targeted by internal links and unreferenced anchors rendered nothing; now each slide begins with a
slide-Nanchor, and Markdown emits<a id="slide-N"></a>for PPT/PPTX.Block::ParagraphwithInline::Anchor("slide-N")before each slide; numbering follows presentation order and empty slides keep anchors. Removed targeted-slide detection in PPTX; droppedSLIDE_RELandRelationships::iter.MarkdownOptions.render_unlinked_slide_anchors;to_markdown_bytesenables it forFormat::Ppt/Format::Pptx. Other formats still suppress unlinked anchors.Written for commit cb5a21e. Summary will update on new commits.