feat(markdown): emit asset:N hrefs for embedded images - #70
Open
alexiskowalski wants to merge 13 commits into
Open
feat(markdown): emit asset:N hrefs for embedded images#70alexiskowalski wants to merge 13 commits into
alexiskowalski wants to merge 13 commits into
Conversation
added 13 commits
August 8, 2026 22:55
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
|
diff --git a/tests/snapshots/snapshots__docx__handmade-ole.docx.snap b/tests/snapshots/snapshots__docx__handmade-ole.docx.snap
index c9626e8..b9e155d 100644
--- a/tests/snapshots/snapshots__docx__handmade-ole.docx.snap
+++ b/tests/snapshots/snapshots__docx__handmade-ole.docx.snap
@@ -4,4 +4,4 @@ expression: output
---
Before the object
-Embedded object: Excel.Sheet.12
+
diff --git a/tests/snapshots/snapshots__docx__handmade-rich.docx.snap b/tests/snapshots/snapshots__docx__handmade-rich.docx.snap
index 38580ca..9114d99 100644
--- a/tests/snapshots/snapshots__docx__handmade-rich.docx.snap
+++ b/tests/snapshots/snapshots__docx__handmade-rich.docx.snap
@@ -17,6 +17,6 @@ Rich objects follow.

-Embedded object: Excel.Sheet.12
+
After the objects.
diff --git a/tests/snapshots/snapshots__epub__book.epub.snap b/tests/snapshots/snapshots__epub__book.epub.snap
index c0dd0de..96bbaa9 100644
--- a/tests/snapshots/snapshots__epub__book.epub.snap
+++ b/tests/snapshots/snapshots__epub__book.epub.snap
@@ -26,7 +26,7 @@ A list of things:
See [Chapter Two](#epub-text-ch002-xhtml-chapter-two) for the table, or jump straight to [the marked paragraph](#epub-text-ch002-xhtml-markpoint).
- 
+ tiny dot
<a id="epub-text-ch002-xhtml-chapter-two"></a>
diff --git a/tests/snapshots/snapshots__odp__pres.odp.snap b/tests/snapshots/snapshots__odp__pres.odp.snap
index d46d347..e70d94b 100644
--- a/tests/snapshots/snapshots__odp__pres.odp.snap
+++ b/tests/snapshots/snapshots__odp__pres.odp.snap
@@ -17,6 +17,8 @@ Numbers Slide
| --- | --- |
| North | 42 |
+
+
Grouped shapes below.
Inside a group shape.
diff --git a/tests/snapshots/snapshots__pptx__handmade-order.pptx.snap b/tests/snapshots/snapshots__pptx__handmade-order.pptx.snap
index 782ed77..652da2e 100644
--- a/tests/snapshots/snapshots__pptx__handmade-order.pptx.snap
+++ b/tests/snapshots/snapshots__pptx__handmade-order.pptx.snap
@@ -8,4 +8,4 @@ Kicker before the title
Body after the title
-Quarterly numbers
+With it applied, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #63: embedded assets already appear as
Inline::Image { source: Asset(id) }in the document model, but Markdown dropped them to alt text only (or nothing when alt was empty), soto_markdown_bytes()lost positional image markers.Changes
ImageSource::Assetas, whereNis the index intoDocument.assets.ImageSource::Unavailableas alt-text-only (no bytes to reference).asset:Nscheme in the README.Callers can rewrite
asset:Nafter writing asset files out, or keep using the document model for the bytes. This is complementary to approaches that inject resolved URLs.Test plan
cargo test --locked render::markdowncargo test --locked --test snapshots