Skip to content

Remove testapp's package-lock files - #1916

Merged
a-maurice merged 1 commit into
mainfrom
am-package_locks
Sep 3, 2026
Merged

Remove testapp's package-lock files#1916
a-maurice merged 1 commit into
mainfrom
am-package_locks

Conversation

@a-maurice

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Remove the testapp's package-lock file from the Firebase Functions. The important part for users is the package.json file, the package-lock causes confusion about what is required, and would need too many regular updates.

For SDK testing, we want to float forward from required minimums so that we detect problems with future versions ASAP.

We don't want exact reproducibility like an app would


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Sep 3, 2026
@a-maurice
a-maurice requested a review from paulb777 September 3, 2026 22:43
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@a-maurice
a-maurice enabled auto-merge (squash) September 3, 2026 22:59
@a-maurice
a-maurice merged commit 406b4a2 into main Sep 3, 2026
39 of 55 checks passed
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

✅  Integration test succeeded!

Requested by @a-maurice on commit 406b4a2
Last updated: Thu Sep 3 17:27 PDT 2026
View integration test log & download artifacts

@a-maurice
a-maurice deleted the am-package_locks branch September 3, 2026 23:51
@github-actions github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label Sep 4, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants