Use default generator settings for child models without config - #1363
Open
SaaiAravindhRaja wants to merge 1 commit into
Open
Use default generator settings for child models without config#1363SaaiAravindhRaja wants to merge 1 commit into
SaaiAravindhRaja wants to merge 1 commit into
Conversation
✅ Deploy Preview for finos-rune canceled.
|
|
|
SaaiAravindhRaja
marked this pull request as draft
August 9, 2026 15:25
SaaiAravindhRaja
marked this pull request as ready for review
August 9, 2026 15:25
Contributor
|
Hi @SaaiAravindhRaja, this issue has already been addressed in #1337 and #1339 and the fix has been released in DSL 10.4.0 and DSL 9.87.0. The corresponding issue should have been closed - sorry for missing it. Out of curiosity, have you ran into this issue after upgrading to one of the above DSL versions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a child model has no
rune-config.yml, the Maven plugin passes no project config. Configuration discovery then treats a dependency's config as the primary config, so the dependency's generator namespace filter is incorrectly applied to the child model.This change distinguishes an unspecified config path from a project that explicitly has no config. Child projects without a config now use the default generator settings while still loading dependency namespace metadata needed for serialization and schema configuration.
Fixes #1334
Verification
mvn -B clean packageType of change