Skip to content

Use default generator settings for child models without config - #1363

Open
SaaiAravindhRaja wants to merge 1 commit into
finos:mainfrom
SaaiAravindhRaja:fix/child-generator-config
Open

Use default generator settings for child models without config#1363
SaaiAravindhRaja wants to merge 1 commit into
finos:mainfrom
SaaiAravindhRaja:fix/child-generator-config

Conversation

@SaaiAravindhRaja

@SaaiAravindhRaja SaaiAravindhRaja commented Aug 9, 2026

Copy link
Copy Markdown

When a child model has no rune-config.yml, the Maven plugin passes no project config. Configuration discovery then treats a dependency's config as the primary config, so the dependency's generator namespace filter is incorrectly applied to the child model.

This change distinguishes an unspecified config path from a project that explicitly has no config. Child projects without a config now use the default generator settings while still loading dependency namespace metadata needed for serialization and schema configuration.

Fixes #1334

Verification

  • mvn -B clean package
  • Python namespace checks: 53 tests passed

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@netlify

netlify Bot commented Aug 9, 2026

Copy link
Copy Markdown

Deploy Preview for finos-rune canceled.

Name Link
🔨 Latest commit 32a9114
🔍 Latest deploy log https://app.netlify.com/projects/finos-rune/deploys/6a789b55a54f0d000838deae

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 9, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: SaaiAravindhRaja / name: Saai Aravindh Raja (32a9114)

@SaaiAravindhRaja
SaaiAravindhRaja marked this pull request as draft August 9, 2026 15:25
@SaaiAravindhRaja
SaaiAravindhRaja marked this pull request as ready for review August 9, 2026 15:25
@SimonCockx

SimonCockx commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Hi @SaaiAravindhRaja, this issue has already been addressed in #1337 and #1339 and the fix has been released in DSL 10.4.0 and DSL 9.87.0.

The corresponding issue should have been closed - sorry for missing it. Out of curiosity, have you ran into this issue after upgrading to one of the above DSL versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code generator filter uses wrong rune-config.yml

2 participants