fix(api): honour and bound StateWaitMsg confidence - #6567
Open
LinZexiao wants to merge 1 commit into
Open
Conversation
- Add MaxMessageConfidence constant (= ChainFinality, 900 epochs) - Add ErrConfidenceTooHigh error for over-limit confidence - Add confidenceReached helper for overflow-safe comparison - Fix: don't return immediately when message found in current head, wait for confidence depth instead (matching Lotus #13705) - Add confidence bound check in Waiter.Wait entry point - Add TestConfidenceReached unit test (6 cases) Migration of Lotus PR #13705
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6567 +/- ##
======================================
- Coverage 22% 22% -1%
======================================
Files 790 790
Lines 83767 83776 +9
======================================
- Hits 18603 18597 -6
- Misses 62293 62306 +13
- Partials 2871 2873 +2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
描述
正确实现 StateWaitMsg 的 confidence 参数处理。
参考: Lotus PR #13705 (filecoin-project/lotus#13705)
改动
pkg/chain/waiter.go
pkg/chain/waiter_internal_test.go (新增)
前置检查