Skip to content

chore(deps): bump wasmtime - #2268

Open
hanabi1224 wants to merge 2 commits into
masterfrom
hm/bump-wasmtime
Open

chore(deps): bump wasmtime#2268
hanabi1224 wants to merge 2 commits into
masterfrom
hm/bump-wasmtime

Conversation

@hanabi1224

@hanabi1224 hanabi1224 commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

This PR upgrades wasmtime to v43 since MSRV requirement has been satisified by #2265

Tipset validation benchmark result:

master:
     Running benches/tipset-validation.rs (target/release/deps/tipset_validation-4fd72144423dc9a0)
Gnuplot not found, using plotters backend
Benchmarking tipset_validation/calibnet@3408952: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 49.6s, or reduce sample count to 10.
tipset_validation/calibnet@3408952
                        time:   [177.21 ms 179.84 ms 182.12 ms]
Found 10 outliers among 100 measurements (10.00%)
  5 (5.00%) low severe
  5 (5.00%) low mild
Benchmarking tipset_validation/mainnet@5709604: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 706.9s, or reduce sample count to 10.
tipset_validation/mainnet@5709604
                        time:   [784.90 ms 801.04 ms 817.74 ms]
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
  
PR:
     Running benches/tipset-validation.rs (target/release/deps/tipset_validation-c0097f4e99d91623)
Benchmarking tipset_validation/calibnet@3408952: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 315.0s, or reduce sample count to 10.
tipset_validation/calibnet@3408952
                        time:   [180.49 ms 182.81 ms 184.82 ms]
Found 11 outliers among 100 measurements (11.00%)
  6 (6.00%) low severe
  4 (4.00%) low mild
  1 (1.00%) high mild
Benchmarking tipset_validation/mainnet@5709604: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 703.3s, or reduce sample count to 10.
tipset_validation/mainnet@5709604
                        time:   [801.28 ms 820.48 ms 840.24 ms]

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Mar 20, 2026
@hanabi1224
hanabi1224 requested a review from rvagg March 20, 2026 11:45
@codecov-commenter

codecov-commenter commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.01%. Comparing base (a29674a) to head (9f2380b).
⚠️ Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
fvm/src/syscalls/error.rs 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2268      +/-   ##
==========================================
- Coverage   77.02%   77.01%   -0.01%     
==========================================
  Files         143      143              
  Lines       14187    14187              
==========================================
- Hits        10927    10926       -1     
- Misses       3260     3261       +1     
Files with missing lines Coverage Δ
fvm/src/engine/mod.rs 81.92% <100.00%> (ø)
fvm/src/machine/limiter.rs 100.00% <ø> (ø)
fvm/src/syscalls/error.rs 48.48% <33.33%> (-3.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hanabi1224
hanabi1224 marked this pull request as ready for review March 26, 2026 13:24

@rvagg rvagg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need a bit of time to walk through this one, I want to do a per-version check since 36 to double check

@rvagg

rvagg commented Apr 16, 2026

Copy link
Copy Markdown
Member

I believe I heard that we were going to hold off on this until after the next schedule network upgrade so it's not super urgent, but we should get to it asap after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📌 Triage

Development

Successfully merging this pull request may close these issues.

3 participants