Issue #2434 - Application update: notification with prompt - #2812
Open
jhou-pro wants to merge 19 commits into
Open
Issue #2434 - Application update: notification with prompt#2812jhou-pro wants to merge 19 commits into
jhou-pro wants to merge 19 commits into
Conversation
…els to client applications. The client-side representation of the update notification is deliberately left out here. It is to be implemented as a toast on this branch. Cherry-picked from dd35874, without the tg-message-panel and tg-app-template parts.
* The watermark may be in the same place where Reload button of the app update message panel. Especially, on mobiles.
…ng import). Extracted from 669702f, without the message panel customisation.
Used firstIp to not add tg-toast to centre. If there is no IP, then probably no toast is okay. https://fielden-software.slack.com/archives/D3SS2KT1P/p1727049139638379 refs #2275
… notification. Unlike tg-toast, which is transient and shares a single slot with all other transient messages, the sticky toast has a slot of its own, so it never gets overridden by other messages and never overrides them. It is appended to the shared toast container, rather than prepended, so that it stays at the bottom and all transient toasts get shifted above it. Stickiness is achieved with duration 0 and no auto-close scheduling, as in tg-delayed-action-toast. A message supports HTML markup, an optional less emphasised second row, an optional row of actions and tap handlers, which follows the API already introduced for tg-message-panel.
… text of the sticky toast.
…ur background. * More roundness to it comparing to standard paper buttons. * No default upper-casing, which is the default for all our paper-buttons and older Material Design, but here it is suitable to have MD3 styled buttons.
…of this issue (see Future Work).
…cy with re-vulcanised login resources.
A span makes its label selectable, which lets Android offer a web search on it when tapped. A paper-button prevents text selection, and is also a proper control in terms of focus and accessibility.
jhou-pro
marked this pull request as ready for review
August 7, 2026 20:45
01es
changed the title
jhou-pro
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2434
To be completed by the pull request creator
This section should be completed with reference to section Preparing PR of the Code and PR reviews wiki page.
Create the pull request as a draft by tapping the dropdown arrow on the 'Create pull request' button under the pull request description (below the text box where this description is being edited) and changing the default
Create pull requesttoDraft pull request.Or, if the pull request has already been created, convert it to draft by tapping the "Convert to draft" link beneath the "Reviewers" section.
A self-review of all changes has been completed, and the changes are in sync with the issue requirements.
Changes to the requirements have been reflected in the issue description.
Any "leftovers" such as sysouts, printing of stack traces, and any other "temporary" code, have been removed.
Minor refactorings, such as renamings, extraction of constants, etc., have been addressed.
Developer documentation (e.g., comments, Javadoc), have been provided where required.
All existing and new Java tests pass successfully by running them with Maven.
All existing and new Web tests pass successfully.
Changes have been inspected for possible NPE situations, and the changes are sufficiently defensive.
The correct base branch has been selected for these changes to be merged into.
The latest changes from the base branch have already been merged into this feature branch (and tested).
Added a change overview to the issue description or as a wiki page, referenced in the issue description.
Some issues might be very descriptive and serve in place of a wiki page.
In such cases consider adding label
Wiki liketo the issue.Changes subject to performance considerations have been evaluated, and tested against production-size data if applicable.
This pull request does contain significant changes, the section "Significant changes" below is completed and at least one Senior Software Engineer with the relevant area of expertise has been selected as reviewer.
The
In progresslabel has been removed from the issue.The
Pull requestlabel has been added to the issue.The pull request has been made ready for review by tapping the "Ready for review" button below the list of commits on the pull request page.
Significant changes
This pull request contains significant changes as defined in the wiki page.
Details are as follows:
The new toast component with distinct UX from existing ones has been added. The details of how it should look has been agreed with @01es.
Reloadbutton should be raised with blue background, with white and bold text caption. And no uppercasing.To be completed by the pull request reviewer
This section should be completed with reference to section Performing PR review of the Code and PR reviews wiki page.
The
In progresslabel has been added to the pull request in GitHub.The issue requirements have been read and understood (along with any relevant emails and/or Slack messages).
The correct base branch is specified, and that base branch is up-to-date in the local source.
The issue branch has been checked out locally, and had the base branch merged into it.
All automated tests pass successfully.
Ensure the implementation satisfies the functional requirements.
Ensure that code changes are secure and align with the established coding practices, including code formatting and naming conventions.
Ensure that code changes are documented and covered with automated tests as applicable.
Ensure that code changes are well-suited for informal reasoning.
Ensure that changes are documented for the end-user (a software engineer in the case of TG, or an application user in the case of TG-based applications).
If there are significant changes (described above), special attention has been paid to them.
Marked the task items in section "Significant changes" as completed to indicate that corresponding changes have been reviewed, improved if necessary, and approved.
The issue or issues addressed by the pull request are associated with the relevant release milestone.
To be completed by the pull request reviewer once the changes have been reviewed and accepted
The changes have been merged into the base branch (unless there is a specific request not to do so, e.g., they are to be released to SIT).
The issue branch has been deleted (unless the changes have not been merged - see above, or there is a specific request not to do so).
The
In progresslabel has been removed from the pull request.The
Pull requestlabel has been removed from the issue.